You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@beam.apache.org by "Luke Cwik (JIRA)" <ji...@apache.org> on 2019/04/02 15:46:02 UTC

[jira] [Assigned] (BEAM-6947) TestGCSIO.test_last_updated (gcsio_test.py) fails when the current timezone offset and the timezone offset on 2nd of Jan 1970 differ

     [ https://issues.apache.org/jira/browse/BEAM-6947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Luke Cwik reassigned BEAM-6947:
-------------------------------

    Assignee: Csaba Kassai

> TestGCSIO.test_last_updated (gcsio_test.py) fails when the current timezone offset and the timezone offset on 2nd of Jan 1970 differ
> ------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: BEAM-6947
>                 URL: https://issues.apache.org/jira/browse/BEAM-6947
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>            Reporter: Csaba Kassai
>            Assignee: Csaba Kassai
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The test TestGCSIO.test_last_updated uses timestamp 123456.78 as the last updated timestamp.  This timestamp is converted into a naive datetime in the Fakefile class get_metadata method (gcsio_test.py line 72) Then in the GcsIO class last_updated method (gcsio.py ) is converted back to timestamp. But the conversion is incorrect when the the timezone offset is different in 1970 and now. In my case now Singapore is GMT+8 and it was only GMT+7:30 in 1970. So the test fails. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)