You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "tju-yxq (via GitHub)" <gi...@apache.org> on 2026/08/11 13:49:48 UTC
[I] [Bug] Plain access whiteRemoteAddress not validated against IP/CIDR format [rocketmq-dashboard]
tju-yxq opened a new issue, #1798:
URL: https://github.com/apache/rocketmq-dashboard/issues/1798
The whiteRemoteAddress field in PlainAccessConfigVO is only trimmed but not validated using IpRangeMatcher. Invalid values like 'foo' or '999.999.999.999' are accepted and persisted to the broker config. The ACL 2.0 whiteSet entries are validated, but ACL 1.0 whiteRemoteAddress is not. Fix: validate whiteRemoteAddress with IpRangeMatcher.isValidRange() before persisting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug] Plain ACL whiteRemoteAddress should be validated before persistence [rocketmq-dashboard]
Posted by "tju-yxq (via GitHub)" <gi...@apache.org>.
tju-yxq closed issue #1798: [Bug] Plain ACL whiteRemoteAddress should be validated before persistence
URL: https://github.com/apache/rocketmq-dashboard/issues/1798
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug] Plain access whiteRemoteAddress not validated against IP/CIDR format [rocketmq-dashboard]
Posted by "tju-yxq (via GitHub)" <gi...@apache.org>.
tju-yxq commented on issue #1798:
URL: https://github.com/apache/rocketmq-dashboard/issues/1798#issuecomment-5269465649
## Clarification after re-checking
The original issue text was too close to a live reproduction report. The current evidence is code inspection plus focused service-layer unit coverage.
The bug being tracked here is specifically that ACL 1.0 plain access config did not validate a non-blank `whiteRemoteAddress` before delegating to the repository, while ACL 2.0 `whiteSet` validation already used `IpRangeMatcher`.
Additional validation added in PR #1799:
```bash
mvn -DskipTests=false -Dtest=AclServiceTest#createAndUpdatePlainAccessConfigShouldRejectInvalidWhiteRemoteAddress+createAndUpdatePlainAccessConfigShouldAcceptValidWhiteRemoteAddress test
```
Result: `BUILD SUCCESS`, `Tests run: 2, Failures: 0, Errors: 0, Skipped: 0`.
The test proves that invalid values are rejected before persistence and valid CIDR values still delegate to the repository.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org