You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by ra0077 <gi...@git.apache.org> on 2016/08/04 21:14:14 UTC
[GitHub] jmeter pull request #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2
GitHub user ra0077 opened a pull request:
https://github.com/apache/jmeter/pull/223
Bug59945_DefaultGroovyEngineToJSR223ElementsV2
Hi,
If the script language has not been chosen on the GUI, I propose to add
a WARN message into the log to inform that the script will be
interpreted as a groovy script
It's avoid message like "ERROR -
jmeter.protocol.java.sampler.JSR223Sampler: Problem in JSR223 script
Echantillon JSR223, message:javax.script.ScriptException: Cannot find
engine named: '', ensure you set language field in JSR223 Test
Element:Echantillon JSR223" and allow to execute the script
Antonio
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ra0077/jmeter Bug59945_DefaultGroovyEngineToJSR223Elements
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/223.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #223
----
commit 8fe20ff7e9cb864b118ec650a854873de19abbac
Author: ra0077 <ra...@gmail.com>
Date: 2016-08-04T21:12:59Z
Bug59945_DefaultGroovyEngineToJSR223ElementsV2
Hi,
If the script language has not been chosen on the GUI, I propose to add
a WARN message into the log to inform that the script will be
interpreted as a groovy script
It's avoid message like "ERROR -
jmeter.protocol.java.sampler.JSR223Sampler: Problem in JSR223 script
Echantillon JSR223, message:javax.script.ScriptException: Cannot find
engine named: '', ensure you set language field in JSR223 Test
Element:Echantillon JSR223" and allow to execute the script
Antonio
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2
Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace commented on the issue:
https://github.com/apache/jmeter/pull/223
Seems better. Fon't forget to update the docs (manual)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2
Posted by ra0077 <gi...@git.apache.org>.
Github user ra0077 commented on the issue:
https://github.com/apache/jmeter/pull/223
PR commited
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2
Posted by vlsi <gi...@git.apache.org>.
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/223
>I don't know how to implement
For instance, a boolean flag that is cleared after the fist warning is printed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2
Posted by ra0077 <gi...@git.apache.org>.
Github user ra0077 closed the pull request at:
https://github.com/apache/jmeter/pull/223
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2
Posted by vlsi <gi...@git.apache.org>.
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/223
-1 for logging a warning on each sampler execution.
Typical user would never open log files, and get bad performance results (or even log overflow of some kind)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2
Posted by vlsi <gi...@git.apache.org>.
Github user vlsi commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/223#discussion_r73605217
--- Diff: src/core/org/apache/jmeter/util/JSR223TestElement.java ---
@@ -86,11 +88,16 @@ public JSR223TestElement() {
}
protected ScriptEngine getScriptEngine() throws ScriptException {
- final String lang = getScriptLanguage();
+ String lang = getScriptLanguage();
+
+ if (lang.isEmpty()) {
+ lang = defaultScriptLanguage;
+ log.warn("Script language has not been chosen on the UI, the script will be interpreted as a groovy script");
--- End diff --
Do you really intend to warn on each and every sampler execution?
This looks awfully broken.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2
Posted by Antonio Gomes Rodrigues <ra...@gmail.com>.
Hi,
Do you mean set the language to groovy in the UI when we had the component?
Antonio
2016-08-11 15:42 GMT+02:00 vlsi <gi...@git.apache.org>:
> Github user vlsi commented on the issue:
>
> https://github.com/apache/jmeter/pull/223
>
> > remove log to avoid performance problem
>
> +1
>
> Technically speaking, I would prefer set the language to "groovy" if
> it was not specified.
>
> That would make the UI clear (user will see what the language is), and
> that would setup proper syntax highlight mode (much easier to program).
> If the conversion is done at load time, then additional log warning is
> just fine as well.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2
Posted by vlsi <gi...@git.apache.org>.
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/223
> remove log to avoid performance problem
+1
Technically speaking, I would prefer set the language to "groovy" if it was not specified.
That would make the UI clear (user will see what the language is), and that would setup proper syntax highlight mode (much easier to program).
If the conversion is done at load time, then additional log warning is just fine as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2
Posted by ra0077 <gi...@git.apache.org>.
Github user ra0077 commented on the issue:
https://github.com/apache/jmeter/pull/223
Hi ubikloadpack,
Your solution seem good
I will implement it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2
Posted by ra0077 <gi...@git.apache.org>.
Github user ra0077 commented on the issue:
https://github.com/apache/jmeter/pull/223
Hi vladimir,
Can you give me more details to avoid logging a warning on each sampler execution?
I don't know how to implement
Thanks
Antonio
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2
Posted by ubikloadpack <gi...@git.apache.org>.
Github user ubikloadpack commented on the issue:
https://github.com/apache/jmeter/pull/223
Hello,
Thanks for PR.
My notes:
- defaultScriptLanguage should be uppercase being a constant.
- use StringUtils.isEmpty to avoid spaces breaking the control
- Maybe a solution to @vlsi note is to set the script , something like this (note that I don't think it will set the lang on the final test but only avoid repeating the log message for the same element each time it runs
` if (StringUtils.isEmpty(lang)) {
lang = DEFAULT_SCRIPT_LANGUAGE;
setScript(lang);
log.warn("Script language has not been chosen on the UI: "+getName()+", the script will be interpreted as a groovy script");
}
`
Regards
@ubikloadpack
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2
Posted by ra0077 <gi...@git.apache.org>.
Github user ra0077 commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/223#discussion_r73664219
--- Diff: src/core/org/apache/jmeter/util/JSR223TestElement.java ---
@@ -86,11 +88,16 @@ public JSR223TestElement() {
}
protected ScriptEngine getScriptEngine() throws ScriptException {
- final String lang = getScriptLanguage();
+ String lang = getScriptLanguage();
+
+ if (lang.isEmpty()) {
+ lang = defaultScriptLanguage;
+ log.warn("Script language has not been chosen on the UI, the script will be interpreted as a groovy script");
--- End diff --
Hi Vladimir,
getScriptEngine method is called for each sampler execution and I am OK with your it's not the best solution for performance.
But you can dynamically change the script language during the execution of the script.
It's why I have made this.
If you have a better solution, please let me know
The other solution will be to don't allow to dynamically modify/change the script language during the execution. But I am not sure it's a good solution.
Antonio
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2
Posted by pmouawad <gi...@git.apache.org>.
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/223
Hello,
In my opinion, you should commit it and we can improve it with further commits.
I agree with @vlsi on the performance involvement of warn logging , but we'll find a solution if you don't want to PR again.
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2
Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace commented on the issue:
https://github.com/apache/jmeter/pull/223
The manual must be updated too for indicate this new behavior (if no language, then groovy script)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2
Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace commented on the issue:
https://github.com/apache/jmeter/pull/223
OK for me too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2
Posted by vlsi <gi...@git.apache.org>.
Github user vlsi commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/223#discussion_r73691076
--- Diff: src/core/org/apache/jmeter/util/ScriptingTestElement.java ---
@@ -36,6 +36,8 @@
private String script = ""; // script (if file not provided)
protected String scriptLanguage = ""; // BSF/JSR223 language to use
+
+ protected final static String defaultScriptLanguage = "groovy"; // if no language is chosen in GUI
--- End diff --
Final static should be written in capital letters
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2
Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/223#discussion_r73644512
--- Diff: src/core/org/apache/jmeter/util/JSR223TestElement.java ---
@@ -86,11 +88,16 @@ public JSR223TestElement() {
}
protected ScriptEngine getScriptEngine() throws ScriptException {
- final String lang = getScriptLanguage();
+ String lang = getScriptLanguage();
+
+ if (lang.isEmpty()) {
+ lang = defaultScriptLanguage;
+ log.warn("Script language has not been chosen on the UI, the script will be interpreted as a groovy script");
+ }
ScriptEngine scriptEngine = getInstance().getEngineByName(lang);
if (scriptEngine == null) {
--- End diff --
The scriptEngine will be never null if groovy become the default language. This (if and exception below) must be changes.
Perhaps put here the test (if lang is undefine then log warn "interpret as groovy script")
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2
Posted by vlsi <gi...@git.apache.org>.
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/223
Do you think a test should be added to cover the change?
An entry in changes.xml is missing as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2
Posted by vlsi <gi...@git.apache.org>.
Github user vlsi commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/223#discussion_r73664814
--- Diff: src/core/org/apache/jmeter/util/JSR223TestElement.java ---
@@ -86,11 +88,16 @@ public JSR223TestElement() {
}
protected ScriptEngine getScriptEngine() throws ScriptException {
- final String lang = getScriptLanguage();
+ String lang = getScriptLanguage();
+
+ if (lang.isEmpty()) {
+ lang = defaultScriptLanguage;
+ log.warn("Script language has not been chosen on the UI, the script will be interpreted as a groovy script");
--- End diff --
>it's not the best solution for performance
JMeter is meant for performance testing. Why do you break the main use case?
1) The `warn` message does not enable user to identify which particular sampler is bad, so it will be impossible to fix large JMeter script. That kind of message is useless.
2) The message should be printed at most once for each sampler for each test execution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2
Posted by ra0077 <gi...@git.apache.org>.
Github user ra0077 commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/223#discussion_r73665279
--- Diff: src/core/org/apache/jmeter/util/JSR223TestElement.java ---
@@ -86,11 +88,16 @@ public JSR223TestElement() {
}
protected ScriptEngine getScriptEngine() throws ScriptException {
- final String lang = getScriptLanguage();
+ String lang = getScriptLanguage();
+
+ if (lang.isEmpty()) {
+ lang = defaultScriptLanguage;
+ log.warn("Script language has not been chosen on the UI, the script will be interpreted as a groovy script");
+ }
ScriptEngine scriptEngine = getInstance().getEngineByName(lang);
if (scriptEngine == null) {
--- End diff --
Hi Milamber,
I have keep the exception because I am not sure that getInstance().getEngineByName("groovy") will always return something.
For example if the groovy jar are missing
Antonio
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2
Posted by ra0077 <gi...@git.apache.org>.
Github user ra0077 commented on the issue:
https://github.com/apache/jmeter/pull/223
Hi all,
I have check in JMeter source code if this "problem" (take a default solution if nothing is setted in GUI) and I have find "CSS/JQuery Extractor" element
If you check the documentation (https://jmeter.apache.org/usermanual/component_reference.html#CSS/JQuery_Extractor), we can read "If selector is set to empty, default implementation(JSoup) will be used"
I have check the source code and make a test and when selector is set to empty, there is no log written.
I propose to make the same thing to this PR (remove log to avoid performance problem + have a clear documentation)
Are you ok?
Antonio
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2
Posted by ra0077 <gi...@git.apache.org>.
Github user ra0077 commented on the issue:
https://github.com/apache/jmeter/pull/223
It's don't work :-(
protected ScriptEngine getScriptEngine() throws ScriptException {
String lang = getScriptLanguage();
if (StringUtils.isEmpty(lang)) {
lang = DEFAULT_SCRIPT_LANGUAGE;
setScriptLanguage(lang);
log.warn("Script language has not been chosen on the UI: "+getName()+", the script will be interpreted as a groovy script");
}
ScriptEngine scriptEngine = getInstance().getEngineByName(lang);
if (scriptEngine == null) {
throw new ScriptException("Cannot find engine named: '"+lang+"', ensure you set language field in JSR223 Test Element: "+getName());
}
return scriptEngine;
}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2
Posted by vlsi <gi...@git.apache.org>.
Github user vlsi commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/223#discussion_r73605191
--- Diff: src/core/org/apache/jmeter/util/ScriptingTestElement.java ---
@@ -36,6 +36,8 @@
private String script = ""; // script (if file not provided)
protected String scriptLanguage = ""; // BSF/JSR223 language to use
+
+ protected String defaultScriptLanguage = "groovy"; // if no language is chosen in GUI
--- End diff --
Should this be `final static`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2
Posted by ra0077 <gi...@git.apache.org>.
Github user ra0077 commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/223#discussion_r73667767
--- Diff: src/core/org/apache/jmeter/util/JSR223TestElement.java ---
@@ -86,11 +88,16 @@ public JSR223TestElement() {
}
protected ScriptEngine getScriptEngine() throws ScriptException {
- final String lang = getScriptLanguage();
+ String lang = getScriptLanguage();
+
+ if (lang.isEmpty()) {
+ lang = defaultScriptLanguage;
+ log.warn("Script language has not been chosen on the UI, the script will be interpreted as a groovy script");
--- End diff --
My first idea was to put Groovy as default script language in the GUI but this solution have a lot of impact (like all the modifications of a default value with compatibility)
The best solution will be to add a "Check script" button to verify the script and advice users of their mistakes and best practices to apply to their script (if you know how to implement it, please share it)
For the moment if the user forget to define a script language, he needs to check the errors in log (by GUI or in the file) and I think it's not user friendly
Call each time getScriptEngine method is already not a good solution for performance (need to check if the JIT don't inline it) because I am not sure that modify dynamically the script language during the execution of the script is very useful feature used by someone (but if you have a use case, please share it)
1) I am OK with you, I can modify the warn message
2) For the moment script language can be modified at each iteration of the test. It means that sometime the script language could be good and sometimes no. If the message is printed only once, it will be incomplete and false.
If we don't modify the behavior of JMeter (allow to dynamically change the script language), the better solution I have is to print a better message. If you have a better solution, please let me know.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2
Posted by ra0077 <gi...@git.apache.org>.
Github user ra0077 commented on the issue:
https://github.com/apache/jmeter/pull/223
Hi,
New patch with better warn message and changes.xml
I am waiting your advices for a better patch
Antonio
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2
Posted by ra0077 <gi...@git.apache.org>.
Github user ra0077 commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/223#discussion_r73661870
--- Diff: src/core/org/apache/jmeter/util/ScriptingTestElement.java ---
@@ -36,6 +36,8 @@
private String script = ""; // script (if file not provided)
protected String scriptLanguage = ""; // BSF/JSR223 language to use
+
+ protected String defaultScriptLanguage = "groovy"; // if no language is chosen in GUI
--- End diff --
Good catch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---