You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by pn...@apache.org on 2022/11/23 09:17:06 UTC

[flink] branch master updated: [FLINK-30155][streaming] Pretty print MutatedConfigurationException

This is an automated email from the ASF dual-hosted git repository.

pnowojski pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git


The following commit(s) were added to refs/heads/master by this push:
     new 011819c5573 [FLINK-30155][streaming] Pretty print MutatedConfigurationException
011819c5573 is described below

commit 011819c557385f1dc7a8e6bc9cacc869f991d207
Author: Piotr Nowojski <pi...@gmail.com>
AuthorDate: Tue Nov 22 17:51:35 2022 +0100

    [FLINK-30155][streaming] Pretty print MutatedConfigurationException
    
    The new message will look like:
    
    org.apache.flink.client.program.MutatedConfigurationException: Not allowed configuration change(s) were detected:
     - Configuration execution.sorted-inputs.enabled:true not allowed.
     - Configuration execution.runtime-mode was changed from STREAMING to BATCH.
     - Configuration execution.checkpointing.interval:500 ms not allowed in the configuration object CheckpointConfig.
     - Configuration execution.checkpointing.mode:EXACTLY_ONCE not allowed in the configuration object CheckpointConfig.
     - Configuration pipeline.max-parallelism:1024 not allowed in the configuration object ExecutionConfig.
     - Configuration parallelism.default:25 not allowed in the configuration object ExecutionConfig.
    
            at org.apache.flink.client.program.StreamContextEnvironment.checkNotAllowedConfigurations(StreamContextEnvironment.java:235)
            at org.apache.flink.client.program.StreamContextEnvironment.executeAsync(StreamContextEnvironment.java:175)
            at org.apache.flink.client.program.StreamContextEnvironment.execute(StreamContextEnvironment.java:115)
            at org.apache.flink.streaming.api.environment.StreamExecutionEnvironment.execute(StreamExecutionEnvironment.java:2049)
            at org.apache.flink.streaming.api.environment.StreamExecutionEnvironment.execute(StreamExecutionEnvironment.java:2027)
    
    Instead of:
    
    org.apache.flink.client.program.MutatedConfigurationException: Configuration execution.sorted-inputs.enabled:true not allowed.
    Configuration execution.runtime-mode was changed from STREAMING to BATCH.
    Configuration execution.checkpointing.interval:500 ms not allowed in the configuration object CheckpointConfig.
    Configuration execution.checkpointing.mode:EXACTLY_ONCE not allowed in the configuration object CheckpointConfig.
    Configuration pipeline.max-parallelism:1024 not allowed in the configuration object ExecutionConfig.
    Configuration parallelism.default:25 not allowed in the configuration object ExecutionConfig.
    
            at org.apache.flink.client.program.StreamContextEnvironment.checkNotAllowedConfigurations(StreamContextEnvironment.java:235)
            at org.apache.flink.client.program.StreamContextEnvironment.executeAsync(StreamContextEnvironment.java:175)
            at org.apache.flink.client.program.StreamContextEnvironment.execute(StreamContextEnvironment.java:115)
            at org.apache.flink.streaming.api.environment.StreamExecutionEnvironment.execute(StreamExecutionEnvironment.java:2049)
            at org.apache.flink.streaming.api.environment.StreamExecutionEnvironment.execute(StreamExecutionEnvironment.java:2027)
---
 .../flink/client/program/MutatedConfigurationException.java   | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/flink-clients/src/main/java/org/apache/flink/client/program/MutatedConfigurationException.java b/flink-clients/src/main/java/org/apache/flink/client/program/MutatedConfigurationException.java
index 379617600ac..05a2f775110 100644
--- a/flink-clients/src/main/java/org/apache/flink/client/program/MutatedConfigurationException.java
+++ b/flink-clients/src/main/java/org/apache/flink/client/program/MutatedConfigurationException.java
@@ -34,6 +34,15 @@ public class MutatedConfigurationException extends Exception {
     private static final long serialVersionUID = -2417524218857151612L;
 
     public MutatedConfigurationException(Collection<String> errorMessages) {
-        super(String.join("\n", errorMessages));
+        super(prettyFormat(errorMessages));
+    }
+
+    private static String prettyFormat(Collection<String> errorMessages) {
+        StringBuilder builder =
+                new StringBuilder("Not allowed configuration change(s) were detected:");
+        for (String error : errorMessages) {
+            builder.append("\n - " + error);
+        }
+        return builder.toString();
     }
 }