You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2016/03/01 21:04:28 UTC

Review Request 44225: Modified docs to add info on `MESOS_SHUTDOWN_GRACE_PERIOD`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44225/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Bugs: MESOS-4829
    https://issues.apache.org/jira/browse/MESOS-4829


Repository: mesos


Description
-------

See summary.


Diffs
-----

  docs/executor-http-api.md e41c2d2d6342153ede4f60f4cc132d880644e7cc 

Diff: https://reviews.apache.org/r/44225/diff/


Testing
-------

make check


Thanks,

Anand Mazumdar


Re: Review Request 44225: Modified docs to add info on `MESOS_EXECUTOR_SHUTDOWN_GRACE_PERIOD`.

Posted by Vinod Kone <vi...@gmail.com>.

> On March 1, 2016, 8:25 p.m., Vinod Kone wrote:
> > Rename the env variable per my previous comment.

Can update the summary?


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44225/#review121490
-----------------------------------------------------------


On March 1, 2016, 9:28 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44225/
> -----------------------------------------------------------
> 
> (Updated March 1, 2016, 9:28 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4829
>     https://issues.apache.org/jira/browse/MESOS-4829
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/executor-http-api.md e41c2d2d6342153ede4f60f4cc132d880644e7cc 
> 
> Diff: https://reviews.apache.org/r/44225/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Re: Review Request 44225: Modified docs to add info on `MESOS_SHUTDOWN_GRACE_PERIOD`.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44225/#review121490
-----------------------------------------------------------


Ship it!




Rename the env variable per my previous comment.

- Vinod Kone


On March 1, 2016, 8:04 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44225/
> -----------------------------------------------------------
> 
> (Updated March 1, 2016, 8:04 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4829
>     https://issues.apache.org/jira/browse/MESOS-4829
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/executor-http-api.md e41c2d2d6342153ede4f60f4cc132d880644e7cc 
> 
> Diff: https://reviews.apache.org/r/44225/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Re: Review Request 44225: Modified docs to add info on `MESOS_EXECUTOR_SHUTDOWN_GRACE_PERIOD`.

Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44225/
-----------------------------------------------------------

(Updated March 1, 2016, 9:28 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Modifed summary.


Summary (updated)
-----------------

Modified docs to add info on `MESOS_EXECUTOR_SHUTDOWN_GRACE_PERIOD`.


Bugs: MESOS-4829
    https://issues.apache.org/jira/browse/MESOS-4829


Repository: mesos


Description
-------

See summary.


Diffs
-----

  docs/executor-http-api.md e41c2d2d6342153ede4f60f4cc132d880644e7cc 

Diff: https://reviews.apache.org/r/44225/diff/


Testing
-------

make check


Thanks,

Anand Mazumdar


Re: Review Request 44225: Modified docs to add info on `MESOS_SHUTDOWN_GRACE_PERIOD`.

Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44225/
-----------------------------------------------------------

(Updated March 1, 2016, 9:14 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Modifed environment variable name.


Bugs: MESOS-4829
    https://issues.apache.org/jira/browse/MESOS-4829


Repository: mesos


Description
-------

See summary.


Diffs (updated)
-----

  docs/executor-http-api.md e41c2d2d6342153ede4f60f4cc132d880644e7cc 

Diff: https://reviews.apache.org/r/44225/diff/


Testing
-------

make check


Thanks,

Anand Mazumdar