You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/12/02 07:26:44 UTC
[GitHub] [apisix-helm-chart] Gallardot opened a new pull request #185: feat: add extra labels and annotations for service monitor
Gallardot opened a new pull request #185:
URL: https://github.com/apache/apisix-helm-chart/pull/185
If [servicemonitors.matchLabels](https://github.com/prometheus-operator/prometheus-operator/blob/main/Documentation/user-guides/getting-started.md#include-servicemonitors) are enabled, we need some extra labels for service monitor
link: #76 #87
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on a change in pull request #185: feat: add extra labels and annotations for service monitor
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on a change in pull request #185:
URL: https://github.com/apache/apisix-helm-chart/pull/185#discussion_r760853376
##########
File path: charts/apisix-ingress-controller/values.yaml
##########
@@ -124,3 +124,9 @@ serviceMonitor:
enabled: false
namespace: "monitoring"
interval: 15s
+ ## @param serviceMonitor.labels ServiceMonitor extra labels
Review comment:
You can delete the extra # to keep it consistent with other comments.
```suggestion
# @param serviceMonitor.labels ServiceMonitor extra labels
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 merged pull request #185: feat: add extra labels and annotations for service monitor
Posted by GitBox <gi...@apache.org>.
tao12345666333 merged pull request #185:
URL: https://github.com/apache/apisix-helm-chart/pull/185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] Gallardot commented on a change in pull request #185: feat: add extra labels and annotations for service monitor
Posted by GitBox <gi...@apache.org>.
Gallardot commented on a change in pull request #185:
URL: https://github.com/apache/apisix-helm-chart/pull/185#discussion_r760863284
##########
File path: charts/apisix-ingress-controller/values.yaml
##########
@@ -124,3 +124,9 @@ serviceMonitor:
enabled: false
namespace: "monitoring"
interval: 15s
+ ## @param serviceMonitor.labels ServiceMonitor extra labels
Review comment:
done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org