[jira] [Commented] (HBASE-14705) Javadoc for KeyValue constructor is not correct.

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-14705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976590#comment-14976590 ] 

Hadoop QA commented on HBASE-14705:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12768979/HBASE-14705-trunk.patch
  against master branch at commit 4269c7fe69baabbd813dcdf6ed0b3a57ea4b41de.
  ATTACHMENT ID: 12768979

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/16247//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16247//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/16247//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16247//console

This message is automatically generated.

> Javadoc for KeyValue constructor is not correct.
> ------------------------------------------------
>
>                 Key: HBASE-14705
>                 URL: https://issues.apache.org/jira/browse/HBASE-14705
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.1.2
>            Reporter: Jean-Marc Spaggiari
>            Assignee: Jean-Marc Spaggiari
>            Priority: Minor
>         Attachments: HBASE-14705-trunk.patch
>
>
> {code}
>   /**
>    * Constructs KeyValue structure filled with null value.
>    * @param row - row key (arbitrary byte array)
>    * @param family family name
>    * @param qualifier column qualifier
>    */
>   public KeyValue(final byte [] row, final byte [] family,
>       final byte [] qualifier, final byte [] value) {
>     this(row, family, qualifier, HConstants.LATEST_TIMESTAMP, Type.Put, value);
>   }
> {code}
> Value is not filled with null.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)