[GitHub] [airflow] pierrejeambrun commented on pull request #34568: Fix: make dry run optional for patch task instance

["pierrejeambrun (via GitHub)" <gi...@apache.org>]

pierrejeambrun commented on PR #34568:
URL: https://github.com/apache/airflow/pull/34568#issuecomment-1732591636

   Yes, all other `dry_run` params default to True in other routes, the only 2 that do not in the doc are:
   - https://airflow.apache.org/docs/apache-airflow/stable/stable-rest-api-ref.html#operation/patch_task_instance
   - https://airflow.apache.org/docs/apache-airflow/stable/stable-rest-api-ref.html#operation/patch_mapped_task_instance
   
   I think defaulting to true makes more sense, and is more conservative, unless explicitly stated by the user with a dry_run=False, we should run in dry run mode.
   
   Also just for a consistency reason, dry_run should be True. Updating the doc and the schema will in one place will fix the both endpoints mentioned. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org