[jira] [Commented] (AIRFLOW-4455) dag_details broken for subdags in RBAC UI

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866416#comment-16866416 ] 

ASF subversion and git services commented on AIRFLOW-4455:
----------------------------------------------------------

Commit 7043572de5ad6e59ac2e93a432a3a3b5171b8987 in airflow's branch refs/heads/v1-10-stable from JCoder01
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=7043572 ]

[AIRFLOW-4455] dag_details broken for subdags in RBAC UI (#5234)

* [AIRFLOW-4455] dag_details broken for subdags in RBAC UI

* [AIRFLOW-4455] dag_details broken for subdags in RBAC UI
Add assert to test_sync_to_db to confirm subdag.fileloc == dag.fileloc
Add new test test_dag_details_subdag to check dag_details endpoint for subdags.

* [AIRFLOW-4479] ImapAttachmentToS3Operator s3_overwrite arg not wired up.
Add replace=self.s3_overwrite to s3_hook.load_bytes

* [AIRFLOW-4479] ImapAttachmentToS3Operator s3_overwrite arg not wired up.
fix test

* Revert "Imap to s3 overwrite not wired up"

(cherry picked from commit 118492e82bcd5207ef1d09c569c31a1243553d82)


> dag_details broken for subdags in RBAC UI
> -----------------------------------------
>
>                 Key: AIRFLOW-4455
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4455
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: ui
>    Affects Versions: 1.10.3
>            Reporter: James Coder
>            Priority: Major
>              Labels: regression, webapp
>             Fix For: 1.10.4
>
>
> With the release of 1.10.3 dagbag was removed from the dag_details view. This appears to have broken the dag details view for subdags. [line 1484|https://github.com/apache/airflow/blob/cec54947d7cf0489284995a6a899b9b94620e301/airflow/models/dag.py#L1484] in models/Dag.py now uses the dag fileloc to get the dag, however for a subdag, the file loc may not contain the dag if the dag is defined in a function as recommended.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)