[GitHub] [hbase] Apache9 commented on a change in pull request #3204: HBASE-25741: Replication Source still having the replication metrics for peer ID which doesn't exist

[GitBox <gi...@apache.org>]

Apache9 commented on a change in pull request #3204:
URL: https://github.com/apache/hbase/pull/3204#discussion_r624692362



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java
##########
@@ -641,8 +641,8 @@ public void removePeer(String id) {
             "and that replication on this peer may not be caught up. peerId=" + id);
       }
       for (ReplicationSourceInterface toRemove : srcToRemove) {
-        toRemove.terminate(terminateMessage);
         closeQueue(toRemove);
+        toRemove.terminate(terminateMessage);

Review comment:
       So this is for branch-1 only? I can not recall the exact logic for branch-1 as it has been changed a lot on branch-2+, as now we do not depend on zk notification...
   
   So just go ahead if you guys find the root cause.
   
   Thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org