You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Julian Foad <ju...@btopenworld.com> on 2006/03/13 12:14:15 UTC
[PATCH] Correct two doc strings and rename a local type for clarity.
Any problems with this?
- Julian
Re: [PATCH] Correct two doc strings and rename a local type for clarity.
Posted by "Peter N. Lundblad" <pe...@famlundblad.se>.
Julian Foad writes:
> Any problems with this?
>
Looks good. +1.
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Correct two doc strings and rename a local type for clarity.
Posted by Julian Foad <ju...@btopenworld.com>.
Malcolm Rowe wrote:
>
> +1, looks good, only one extra comment below. It's nice to have someone
> else looking at diff, thanks Julian!
Ugh. I've been meaning to for years, and it's because you are interested that
I'm having another go now. It's making my head spin. It really is time we
generalised this code to get rid of lots of the special cases (e.g. that
repo-repos diff supports both single-object-at-two-revisions and
two-independent-objects modes, whereas wc-wc diff doesn't).
>>@@ -2457,11 +2358,6 @@ do_diff_summarize_peg(const struct diff_
>> Svn_client_diff3() is the single entry point for all of the diff
>
> "svn_client_diff3()"? Even though it is as the start of the sentence.
Oh yes, I might as well change that while I'm at it.
>> operations, and will be in charge of examining the inputs and
>
> "is in charge"? Or perhaps drop everything after the comma - it doesn't
> add much.
Yes. Now I look at it, the first half of the sentence isn't true any more
(there are multiple entry points) so I'll drop the whole thing.
Thanks for the review.
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Correct two doc strings and rename a local type for clarity.
Posted by Malcolm Rowe <ma...@farside.org.uk>.
On Mon, Mar 13, 2006 at 12:14:15PM +0000, Julian Foad wrote:
> Any problems with this?
>
+1, looks good, only one extra comment below. It's nice to have someone
else looking at diff, thanks Julian!
> @@ -2457,11 +2358,6 @@ do_diff_summarize_peg(const struct diff_
> Svn_client_diff3() is the single entry point for all of the diff
"svn_client_diff3()"? Even though it is as the start of the sentence.
> operations, and will be in charge of examining the inputs and
"is in charge"? Or perhaps drop everything after the comma - it doesn't
add much.
> making decisions about how to accurately report contextual diffs.
> -
> - NOTE: In the near future, svn_client_diff3() will likely only
> - continue to report textual differences in files. Property diffs
> - are important, too, and will need to be supported in some fashion
> - so that this code can be re-used for svn_client_merge().
> */
> svn_error_t *
> svn_client_diff3(const apr_array_header_t *options,
Regards,
Malcolm
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org