You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/06/25 02:43:15 UTC
Review Request 22948: Add a script that allows for easy selective rebuilding
of components in the vagrant environment.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22948/
-----------------------------------------------------------
Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Maxim Khutornenko.
Repository: aurora
Description
-------
Some context for this review can be found in:
https://reviews.apache.org/r/20648/
https://reviews.apache.org/r/22008/
This is a step towards making it simpler to iterate on code in the vagrant environment. If i'm developing on the observer, i can make my edits and then run:
$ vagrant ssh -c 'aurorabuild observer'
Diffs
-----
examples/vagrant/aurorabuild.sh PRE-CREATION
examples/vagrant/provision-dev-cluster.sh f6459a15887299038165f0e0dde22015392e0d0f
Diff: https://reviews.apache.org/r/22948/diff/
Testing
-------
vagrant up && bash examples/vagrant/test_tutorial.sh
I will update this section once i have run end-to-end tests, and will not submit until this section is updated.
Thanks,
Bill Farner
Re: Review Request 22948: Add a script that allows for easy selective
rebuilding of components in the vagrant environment.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22948/#review46890
-----------------------------------------------------------
Ship it!
Ship It!
- Mark Chu-Carroll
On June 24, 2014, 8:43 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22948/
> -----------------------------------------------------------
>
> (Updated June 24, 2014, 8:43 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Some context for this review can be found in:
> https://reviews.apache.org/r/20648/
> https://reviews.apache.org/r/22008/
>
> This is a step towards making it simpler to iterate on code in the vagrant environment. If i'm developing on the observer, i can make my edits and then run:
>
> $ vagrant ssh -c 'aurorabuild observer'
>
>
> Diffs
> -----
>
> examples/vagrant/aurorabuild.sh PRE-CREATION
> examples/vagrant/provision-dev-cluster.sh f6459a15887299038165f0e0dde22015392e0d0f
>
> Diff: https://reviews.apache.org/r/22948/diff/
>
>
> Testing
> -------
>
> vagrant up && bash examples/vagrant/test_tutorial.sh
>
> I will update this section once i have run end-to-end tests, and will not submit until this section is updated.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 22948: Add a script that allows for easy selective
rebuilding of components in the vagrant environment.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22948/#review46808
-----------------------------------------------------------
Ping - Kevin, Mark?
- Bill Farner
On June 25, 2014, 12:43 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22948/
> -----------------------------------------------------------
>
> (Updated June 25, 2014, 12:43 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Some context for this review can be found in:
> https://reviews.apache.org/r/20648/
> https://reviews.apache.org/r/22008/
>
> This is a step towards making it simpler to iterate on code in the vagrant environment. If i'm developing on the observer, i can make my edits and then run:
>
> $ vagrant ssh -c 'aurorabuild observer'
>
>
> Diffs
> -----
>
> examples/vagrant/aurorabuild.sh PRE-CREATION
> examples/vagrant/provision-dev-cluster.sh f6459a15887299038165f0e0dde22015392e0d0f
>
> Diff: https://reviews.apache.org/r/22948/diff/
>
>
> Testing
> -------
>
> vagrant up && bash examples/vagrant/test_tutorial.sh
>
> I will update this section once i have run end-to-end tests, and will not submit until this section is updated.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 22948: Add a script that allows for easy selective
rebuilding of components in the vagrant environment.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22948/#review46911
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On June 24, 2014, 5:43 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22948/
> -----------------------------------------------------------
>
> (Updated June 24, 2014, 5:43 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Some context for this review can be found in:
> https://reviews.apache.org/r/20648/
> https://reviews.apache.org/r/22008/
>
> This is a step towards making it simpler to iterate on code in the vagrant environment. If i'm developing on the observer, i can make my edits and then run:
>
> $ vagrant ssh -c 'aurorabuild observer'
>
>
> Diffs
> -----
>
> examples/vagrant/aurorabuild.sh PRE-CREATION
> examples/vagrant/provision-dev-cluster.sh f6459a15887299038165f0e0dde22015392e0d0f
>
> Diff: https://reviews.apache.org/r/22948/diff/
>
>
> Testing
> -------
>
> vagrant up && bash examples/vagrant/test_tutorial.sh
>
> I will update this section once i have run end-to-end tests, and will not submit until this section is updated.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 22948: Add a script that allows for easy selective
rebuilding of components in the vagrant environment.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22948/
-----------------------------------------------------------
(Updated July 1, 2014, 7:36 p.m.)
Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Maxim Khutornenko.
Repository: aurora
Description
-------
Some context for this review can be found in:
https://reviews.apache.org/r/20648/
https://reviews.apache.org/r/22008/
This is a step towards making it simpler to iterate on code in the vagrant environment. If i'm developing on the observer, i can make my edits and then run:
$ vagrant ssh -c 'aurorabuild observer'
Diffs
-----
docs/vagrant.md 8c676727b2d164e1e50fb7326accc9a74aa236f1
examples/vagrant/aurorabuild.sh PRE-CREATION
examples/vagrant/provision-dev-cluster.sh f6459a15887299038165f0e0dde22015392e0d0f
Diff: https://reviews.apache.org/r/22948/diff/
Testing (updated)
-------
vagrant up && bash examples/vagrant/test_tutorial.sh
Unfortunately end-to-end tests don't pass for me with this change and on master. Since client functionality was unchanged, and other vagrant operations work, i'm going to chalk that up to a transient issue or brokenness with the test itself.
Thanks,
Bill Farner
Re: Review Request 22948: Add a script that allows for easy selective
rebuilding of components in the vagrant environment.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22948/
-----------------------------------------------------------
(Updated July 1, 2014, 6:36 p.m.)
Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Maxim Khutornenko.
Changes
-------
Added instructions in docs/vagrant.md.
Repository: aurora
Description
-------
Some context for this review can be found in:
https://reviews.apache.org/r/20648/
https://reviews.apache.org/r/22008/
This is a step towards making it simpler to iterate on code in the vagrant environment. If i'm developing on the observer, i can make my edits and then run:
$ vagrant ssh -c 'aurorabuild observer'
Diffs (updated)
-----
docs/vagrant.md 8c676727b2d164e1e50fb7326accc9a74aa236f1
examples/vagrant/aurorabuild.sh PRE-CREATION
examples/vagrant/provision-dev-cluster.sh f6459a15887299038165f0e0dde22015392e0d0f
Diff: https://reviews.apache.org/r/22948/diff/
Testing
-------
vagrant up && bash examples/vagrant/test_tutorial.sh
I will update this section once i have run end-to-end tests, and will not submit until this section is updated.
Thanks,
Bill Farner
Re: Review Request 22948: Add a script that allows for easy selective
rebuilding of components in the vagrant environment.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22948/
-----------------------------------------------------------
(Updated June 30, 2014, 10:33 p.m.)
Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Maxim Khutornenko.
Changes
-------
Fixed a few minor issues. I've confirmed that creating the vagrant environment works as before, still need to verify that rebuilding works cleanly.
Repository: aurora
Description
-------
Some context for this review can be found in:
https://reviews.apache.org/r/20648/
https://reviews.apache.org/r/22008/
This is a step towards making it simpler to iterate on code in the vagrant environment. If i'm developing on the observer, i can make my edits and then run:
$ vagrant ssh -c 'aurorabuild observer'
Diffs (updated)
-----
examples/vagrant/aurorabuild.sh PRE-CREATION
examples/vagrant/provision-dev-cluster.sh f6459a15887299038165f0e0dde22015392e0d0f
Diff: https://reviews.apache.org/r/22948/diff/
Testing
-------
vagrant up && bash examples/vagrant/test_tutorial.sh
I will update this section once i have run end-to-end tests, and will not submit until this section is updated.
Thanks,
Bill Farner
Re: Review Request 22948: Add a script that allows for easy selective
rebuilding of components in the vagrant environment.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22948/#review46757
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On June 25, 2014, 12:43 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22948/
> -----------------------------------------------------------
>
> (Updated June 25, 2014, 12:43 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Some context for this review can be found in:
> https://reviews.apache.org/r/20648/
> https://reviews.apache.org/r/22008/
>
> This is a step towards making it simpler to iterate on code in the vagrant environment. If i'm developing on the observer, i can make my edits and then run:
>
> $ vagrant ssh -c 'aurorabuild observer'
>
>
> Diffs
> -----
>
> examples/vagrant/aurorabuild.sh PRE-CREATION
> examples/vagrant/provision-dev-cluster.sh f6459a15887299038165f0e0dde22015392e0d0f
>
> Diff: https://reviews.apache.org/r/22948/diff/
>
>
> Testing
> -------
>
> vagrant up && bash examples/vagrant/test_tutorial.sh
>
> I will update this section once i have run end-to-end tests, and will not submit until this section is updated.
>
>
> Thanks,
>
> Bill Farner
>
>