You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "privking (via GitHub)" <gi...@apache.org> on 2024/04/18 17:19:27 UTC
[PR] [FIX] Fix failure to recover stopped instance [dolphinscheduler]
privking opened a new pull request, #15880:
URL: https://github.com/apache/dolphinscheduler/pull/15880
<!--Thanks very much for contributing to Apache DolphinScheduler, we are happy that you want to help us improve DolphinScheduler! -->
## Purpose of the pull request
Fix failure to recover stopped instance
<img width="1634" alt="error" src="https://github.com/apache/dolphinscheduler/assets/43061765/cea59521-f325-4bf2-9834-e75f6a223520">
<!--(For example: This pull request adds checkstyle plugin).-->
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
(or)
If your pull request contain incompatible change, you should also add it to `docs/docs/en/guide/upgrede/incompatible.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FIX] Fix failure to recover stopped instance [dolphinscheduler]
Posted by "privking (via GitHub)" <gi...@apache.org>.
privking commented on PR #15880:
URL: https://github.com/apache/dolphinscheduler/pull/15880#issuecomment-2066398130
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FIX] Fix failure to recover stopped instance [dolphinscheduler]
Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun merged PR #15880:
URL: https://github.com/apache/dolphinscheduler/pull/15880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FIX] Fix failure to recover stopped instance [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15880:
URL: https://github.com/apache/dolphinscheduler/pull/15880#issuecomment-2066450078
Please retry analysis of this Pull-Request directly on SonarCloud
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FIX] Fix failure to recover stopped instance [dolphinscheduler]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #15880:
URL: https://github.com/apache/dolphinscheduler/pull/15880#issuecomment-2066440161
## [Codecov](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15880?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `0%` with `1 lines` in your changes are missing coverage. Please review.
> Project coverage is 39.53%. Comparing base [(`285c5a8`)](https://app.codecov.io/gh/apache/dolphinscheduler/commit/285c5a8eb541f46b6e7b508729ba4b5178d09152?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`15ebdcd`)](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15880?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> :exclamation: Current head 15ebdcd differs from pull request most recent head ade8ae6. Consider uploading reports for the commit ade8ae6 to get more accurate results
| [Files](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15880?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...instance/pause/recover/RecoverExecuteFunction.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15880?src=pr&el=tree&filepath=dolphinscheduler-api%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fdolphinscheduler%2Fapi%2Fexecutor%2Fworkflow%2Finstance%2Fpause%2Frecover%2FRecoverExecuteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2V4ZWN1dG9yL3dvcmtmbG93L2luc3RhbmNlL3BhdXNlL3JlY292ZXIvUmVjb3ZlckV4ZWN1dGVGdW5jdGlvbi5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15880?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## dev #15880 +/- ##
============================================
- Coverage 39.60% 39.53% -0.07%
+ Complexity 5015 4994 -21
============================================
Files 1349 1349
Lines 45578 45543 -35
Branches 4886 4863 -23
============================================
- Hits 18051 18006 -45
- Misses 25609 25619 +10
Partials 1918 1918
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15880?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FIX] Fix failure to recover stopped instance [dolphinscheduler]
Posted by "rickchengx (via GitHub)" <gi...@apache.org>.
rickchengx commented on PR #15880:
URL: https://github.com/apache/dolphinscheduler/pull/15880#issuecomment-2066048944
@privking please run 'mvn spotless:apply' to fix the code style
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org