You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Sanjay Radia (Created) (JIRA)" <ji...@apache.org> on 2012/03/19 18:37:37 UTC
[jira] [Created] (HADOOP-8184) ProtoBuf RPC engine does not need it
own reply packet - it can use the IPC layer reply packet.
ProtoBuf RPC engine does not need it own reply packet - it can use the IPC layer reply packet.
----------------------------------------------------------------------------------------------
Key: HADOOP-8184
URL: https://issues.apache.org/jira/browse/HADOOP-8184
Project: Hadoop Common
Issue Type: Improvement
Reporter: Sanjay Radia
Assignee: Sanjay Radia
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8184) ProtoBuf RPC engine does not need
it own reply packet - it can use the IPC layer reply packet.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236953#comment-13236953 ]
Hudson commented on HADOOP-8184:
--------------------------------
Integrated in Hadoop-Hdfs-0.23-Commit #710 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/710/])
svn merge -c 1304542 from trunk for HADOOP-8184. (Revision 1304546)
Result = SUCCESS
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304546
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
> ProtoBuf RPC engine does not need it own reply packet - it can use the IPC layer reply packet.
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8184
> URL: https://issues.apache.org/jira/browse/HADOOP-8184
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Fix For: 0.23.3, 0.24.0
>
> Attachments: rpcFixPBHeader2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8184) ProtoBuf RPC engine does not need
it own reply packet - it can use the IPC layer reply packet.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236950#comment-13236950 ]
Hudson commented on HADOOP-8184:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #1994 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1994/])
HADOOP-8184. ProtoBuf RPC engine uses the IPC layer reply packet. Contributed by Sanjay Radia (Revision 1304542)
Result = SUCCESS
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304542
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
> ProtoBuf RPC engine does not need it own reply packet - it can use the IPC layer reply packet.
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8184
> URL: https://issues.apache.org/jira/browse/HADOOP-8184
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Fix For: 0.23.3, 0.24.0
>
> Attachments: rpcFixPBHeader2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8184) ProtoBuf RPC engine does not need it
own reply packet - it can use the IPC layer reply packet.
Posted by "Tsz Wo (Nicholas), SZE (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-8184:
-------------------------------------------
Resolution: Fixed
Fix Version/s: 0.24.0
0.23.3
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Thanks Suresh for the review.
I have committed this. Thanks, Sanjay!
> ProtoBuf RPC engine does not need it own reply packet - it can use the IPC layer reply packet.
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8184
> URL: https://issues.apache.org/jira/browse/HADOOP-8184
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Fix For: 0.23.3, 0.24.0
>
> Attachments: rpcFixPBHeader2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8184) ProtoBuf RPC engine does not need
it own reply packet - it can use the IPC layer reply packet.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237536#comment-13237536 ]
Hudson commented on HADOOP-8184:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #1029 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1029/])
HADOOP-8184. ProtoBuf RPC engine uses the IPC layer reply packet. Contributed by Sanjay Radia (Revision 1304542)
Result = SUCCESS
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304542
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
> ProtoBuf RPC engine does not need it own reply packet - it can use the IPC layer reply packet.
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8184
> URL: https://issues.apache.org/jira/browse/HADOOP-8184
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Fix For: 0.23.3, 0.24.0
>
> Attachments: rpcFixPBHeader2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8184) ProtoBuf RPC engine does not need
it own reply packet - it can use the IPC layer reply packet.
Posted by "Aaron T. Myers (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239906#comment-13239906 ]
Aaron T. Myers commented on HADOOP-8184:
----------------------------------------
bq. Sure, I will take a look.
Thanks a lot!
bq. We usually do not revert patches because of unit test failures.
In my experience we've often done this (see HADOOP-8193 for example) but if you'll look into it promptly then it seems fine not to.
> ProtoBuf RPC engine does not need it own reply packet - it can use the IPC layer reply packet.
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8184
> URL: https://issues.apache.org/jira/browse/HADOOP-8184
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Fix For: 0.23.3, 0.24.0
>
> Attachments: rpcFixPBHeader2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8184) ProtoBuf RPC engine does not need it
own reply packet - it can use the IPC layer reply packet.
Posted by "Sanjay Radia (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sanjay Radia updated HADOOP-8184:
---------------------------------
Attachment: rpcFixPBHeader2.patch
> ProtoBuf RPC engine does not need it own reply packet - it can use the IPC layer reply packet.
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8184
> URL: https://issues.apache.org/jira/browse/HADOOP-8184
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Attachments: rpcFixPBHeader2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8184) ProtoBuf RPC engine does not need
it own reply packet - it can use the IPC layer reply packet.
Posted by "Aaron T. Myers (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238076#comment-13238076 ]
Aaron T. Myers commented on HADOOP-8184:
----------------------------------------
Hi Sanjay and Nicholas, this patch seems to have broken TestHDFSCLI and TestGetBlocks in HDFS, since it appears that the exception class name is no longer being sent when a remote error is encountered. Could you please look into this?
In the mean time, I suggest we revert these commits from trunk and branch-0.23 until these two tests can be fixed.
> ProtoBuf RPC engine does not need it own reply packet - it can use the IPC layer reply packet.
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8184
> URL: https://issues.apache.org/jira/browse/HADOOP-8184
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Fix For: 0.23.3, 0.24.0
>
> Attachments: rpcFixPBHeader2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8184) ProtoBuf RPC engine does not need
it own reply packet - it can use the IPC layer reply packet.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236967#comment-13236967 ]
Hudson commented on HADOOP-8184:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #1929 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1929/])
HADOOP-8184. ProtoBuf RPC engine uses the IPC layer reply packet. Contributed by Sanjay Radia (Revision 1304542)
Result = ABORTED
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304542
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
> ProtoBuf RPC engine does not need it own reply packet - it can use the IPC layer reply packet.
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8184
> URL: https://issues.apache.org/jira/browse/HADOOP-8184
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Fix For: 0.23.3, 0.24.0
>
> Attachments: rpcFixPBHeader2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8184) ProtoBuf RPC engine does not need
it own reply packet - it can use the IPC layer reply packet.
Posted by "Tsz Wo (Nicholas), SZE (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239851#comment-13239851 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-8184:
------------------------------------------------
Sure, I will take a look.
> In the mean time, I suggest we revert these commits from trunk and branch-0.23 until these two tests can be fixed.
We usually do not revert patches because of unit test failures.
> ProtoBuf RPC engine does not need it own reply packet - it can use the IPC layer reply packet.
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8184
> URL: https://issues.apache.org/jira/browse/HADOOP-8184
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Fix For: 0.23.3, 0.24.0
>
> Attachments: rpcFixPBHeader2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8184) ProtoBuf RPC engine does not need
it own reply packet - it can use the IPC layer reply packet.
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232782#comment-13232782 ]
Hadoop QA commented on HADOOP-8184:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12518915/rpcFixPBHeader2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/729//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/729//console
This message is automatically generated.
> ProtoBuf RPC engine does not need it own reply packet - it can use the IPC layer reply packet.
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8184
> URL: https://issues.apache.org/jira/browse/HADOOP-8184
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Attachments: rpcFixPBHeader2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8184) ProtoBuf RPC engine does not need
it own reply packet - it can use the IPC layer reply packet.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236930#comment-13236930 ]
Hudson commented on HADOOP-8184:
--------------------------------
Integrated in Hadoop-Common-0.23-Commit #719 (See [https://builds.apache.org/job/Hadoop-Common-0.23-Commit/719/])
svn merge -c 1304542 from trunk for HADOOP-8184. (Revision 1304546)
Result = SUCCESS
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304546
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
> ProtoBuf RPC engine does not need it own reply packet - it can use the IPC layer reply packet.
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8184
> URL: https://issues.apache.org/jira/browse/HADOOP-8184
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Fix For: 0.23.3, 0.24.0
>
> Attachments: rpcFixPBHeader2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8184) ProtoBuf RPC engine does not need
it own reply packet - it can use the IPC layer reply packet.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237514#comment-13237514 ]
Hudson commented on HADOOP-8184:
--------------------------------
Integrated in Hadoop-Hdfs-0.23-Build #207 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/207/])
svn merge -c 1304542 from trunk for HADOOP-8184. (Revision 1304546)
Result = UNSTABLE
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304546
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
> ProtoBuf RPC engine does not need it own reply packet - it can use the IPC layer reply packet.
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8184
> URL: https://issues.apache.org/jira/browse/HADOOP-8184
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Fix For: 0.23.3, 0.24.0
>
> Attachments: rpcFixPBHeader2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8184) ProtoBuf RPC engine does not need
it own reply packet - it can use the IPC layer reply packet.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236968#comment-13236968 ]
Hudson commented on HADOOP-8184:
--------------------------------
Integrated in Hadoop-Mapreduce-0.23-Commit #727 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/727/])
svn merge -c 1304542 from trunk for HADOOP-8184. (Revision 1304546)
Result = ABORTED
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304546
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
> ProtoBuf RPC engine does not need it own reply packet - it can use the IPC layer reply packet.
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8184
> URL: https://issues.apache.org/jira/browse/HADOOP-8184
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Fix For: 0.23.3, 0.24.0
>
> Attachments: rpcFixPBHeader2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8184) ProtoBuf RPC engine does not need
it own reply packet - it can use the IPC layer reply packet.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237519#comment-13237519 ]
Hudson commented on HADOOP-8184:
--------------------------------
Integrated in Hadoop-Mapreduce-0.23-Build #235 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/235/])
svn merge -c 1304542 from trunk for HADOOP-8184. (Revision 1304546)
Result = FAILURE
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304546
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
> ProtoBuf RPC engine does not need it own reply packet - it can use the IPC layer reply packet.
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8184
> URL: https://issues.apache.org/jira/browse/HADOOP-8184
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Fix For: 0.23.3, 0.24.0
>
> Attachments: rpcFixPBHeader2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8184) ProtoBuf RPC engine does not need it
own reply packet - it can use the IPC layer reply packet.
Posted by "Aaron T. Myers (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron T. Myers updated HADOOP-8184:
-----------------------------------
Affects Version/s: 2.0.0
Release Note: This change will affect the output of errors for some Hadoop CLI commands. Specifically, the name of the exception class will no longer appear, and instead only the text of the exception message will appear.
Hadoop Flags: Incompatible change,Reviewed (was: Reviewed)
> ProtoBuf RPC engine does not need it own reply packet - it can use the IPC layer reply packet.
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8184
> URL: https://issues.apache.org/jira/browse/HADOOP-8184
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 2.0.0
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Fix For: 2.0.0
>
> Attachments: rpcFixPBHeader2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8184) ProtoBuf RPC engine does not need it
own reply packet - it can use the IPC layer reply packet.
Posted by "Tsz Wo (Nicholas), SZE (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-8184:
-------------------------------------------
Component/s: ipc
> ProtoBuf RPC engine does not need it own reply packet - it can use the IPC layer reply packet.
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8184
> URL: https://issues.apache.org/jira/browse/HADOOP-8184
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Fix For: 0.23.3, 0.24.0
>
> Attachments: rpcFixPBHeader2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8184) ProtoBuf RPC engine does not need
it own reply packet - it can use the IPC layer reply packet.
Posted by "Tsz Wo (Nicholas), SZE (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239941#comment-13239941 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-8184:
------------------------------------------------
> In my experience we've often done this (see HADOOP-8193 for example) ...
It seems that there are much more examples that we did not revert. Do you agree?
> ProtoBuf RPC engine does not need it own reply packet - it can use the IPC layer reply packet.
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8184
> URL: https://issues.apache.org/jira/browse/HADOOP-8184
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Fix For: 0.23.3, 0.24.0
>
> Attachments: rpcFixPBHeader2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8184) ProtoBuf RPC engine does not need
it own reply packet - it can use the IPC layer reply packet.
Posted by "Suresh Srinivas (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235760#comment-13235760 ]
Suresh Srinivas commented on HADOOP-8184:
-----------------------------------------
Sanjay, thanks for cleaning this up. This needs to be ported to 0.23 as well to keep backward compatibility. +1 for the patch.
> ProtoBuf RPC engine does not need it own reply packet - it can use the IPC layer reply packet.
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8184
> URL: https://issues.apache.org/jira/browse/HADOOP-8184
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Attachments: rpcFixPBHeader2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8184) ProtoBuf RPC engine does not need it
own reply packet - it can use the IPC layer reply packet.
Posted by "Sanjay Radia (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sanjay Radia updated HADOOP-8184:
---------------------------------
Status: Patch Available (was: Open)
> ProtoBuf RPC engine does not need it own reply packet - it can use the IPC layer reply packet.
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8184
> URL: https://issues.apache.org/jira/browse/HADOOP-8184
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Attachments: rpcFixPBHeader2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8184) ProtoBuf RPC engine does not need
it own reply packet - it can use the IPC layer reply packet.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237509#comment-13237509 ]
Hudson commented on HADOOP-8184:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #994 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/994/])
HADOOP-8184. ProtoBuf RPC engine uses the IPC layer reply packet. Contributed by Sanjay Radia (Revision 1304542)
Result = FAILURE
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304542
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
> ProtoBuf RPC engine does not need it own reply packet - it can use the IPC layer reply packet.
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8184
> URL: https://issues.apache.org/jira/browse/HADOOP-8184
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Fix For: 0.23.3, 0.24.0
>
> Attachments: rpcFixPBHeader2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8184) ProtoBuf RPC engine does not need
it own reply packet - it can use the IPC layer reply packet.
Posted by "Aaron T. Myers (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239950#comment-13239950 ]
Aaron T. Myers commented on HADOOP-8184:
----------------------------------------
bq. It seems that there are much more examples that we did not revert.
I haven't done a thorough survey of commits which have broken tests, so couldn't say for sure.
Regardless, thanks for looking into it promptly! I agree there's no need to revert this patch.
> ProtoBuf RPC engine does not need it own reply packet - it can use the IPC layer reply packet.
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8184
> URL: https://issues.apache.org/jira/browse/HADOOP-8184
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Fix For: 0.23.3, 0.24.0
>
> Attachments: rpcFixPBHeader2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8184) ProtoBuf RPC engine does not need
it own reply packet - it can use the IPC layer reply packet.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236947#comment-13236947 ]
Hudson commented on HADOOP-8184:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #1920 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1920/])
HADOOP-8184. ProtoBuf RPC engine uses the IPC layer reply packet. Contributed by Sanjay Radia (Revision 1304542)
Result = SUCCESS
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304542
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
> ProtoBuf RPC engine does not need it own reply packet - it can use the IPC layer reply packet.
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8184
> URL: https://issues.apache.org/jira/browse/HADOOP-8184
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Fix For: 0.23.3, 0.24.0
>
> Attachments: rpcFixPBHeader2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira