Logkit

[Bernhard Huber <bh...@i-one.at>]

As I was testing logkit-1.0b5 "build test" didn't work 
on my W2000K machine.
Testcase FormatterTestCase.java failed, I replaced "\n"
by EOL, and everything was okay.
Moreover I wondered somehow about formatting of date&time,
is it right that today time-value is formatted only as a
long value, or did I missed something?
I added an extension of PatternFormatter, as I think
that a more human readable time formatted will help using
log files.
BTW I added some more javadoc to PatternFormatter, hope it's
correct, see the attaced diff file.

I hope it okay submitting in zip into this list directly....
bye

Re: Logkit

[Peter Donald <do...@apache.org>]

On Tue, 25 Sep 2001 06:03, Bernhard Huber wrote:
> As I was testing logkit-1.0b5 "build test" didn't work
> on my W2000K machine.
> Testcase FormatterTestCase.java failed, I replaced "\n"
> by EOL, and everything was okay.

applied - thanks.

> Moreover I wondered somehow about formatting of date&time,
> is it right that today time-value is formatted only as a
> long value, or did I missed something?

Well there are places where it is formatted like

(new Date( long )).toString() IIRC but yes mostly it is via a long. This is 
mainly for backwards compatability ;(

> I added an extension of PatternFormatter, as I think
> that a more human readable time formatted will help using
> log files.

Yep - I agree. Not sure about the best way to integrate this. We may be able 
to integrate it into directly into main PatternFormatter. Perhaps  

if( null == format ) return Long.toString( time );
else
{
 ...insert your code here....
}

Thoughts?

> BTW I added some more javadoc to PatternFormatter, hope it's
> correct, see the attaced diff file.

applied - thanks.

> I hope it okay submitting in zip into this list directly....

yep - thats good.

-- 
Cheers,

Pete

---------------------------------
I think not; therefore I ain't...
---------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org