You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@paimon.apache.org by lz...@apache.org on 2023/12/27 13:15:41 UTC

(incubator-paimon) branch master updated: [core] Minor improve FieldAggregator#createFieldNestedUpdateAgg (#2587)

This is an automated email from the ASF dual-hosted git repository.

lzljs3620320 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-paimon.git


The following commit(s) were added to refs/heads/master by this push:
     new 793211eea [core] Minor improve FieldAggregator#createFieldNestedUpdateAgg (#2587)
793211eea is described below

commit 793211eea8b93baf9ed1fa8dfb56386d640d22f1
Author: yuzelin <33...@users.noreply.github.com>
AuthorDate: Wed Dec 27 21:15:37 2023 +0800

    [core] Minor improve FieldAggregator#createFieldNestedUpdateAgg (#2587)
---
 .../paimon/mergetree/compact/aggregate/FieldAggregator.java      | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/paimon-core/src/main/java/org/apache/paimon/mergetree/compact/aggregate/FieldAggregator.java b/paimon-core/src/main/java/org/apache/paimon/mergetree/compact/aggregate/FieldAggregator.java
index 5178576fe..6012733e1 100644
--- a/paimon-core/src/main/java/org/apache/paimon/mergetree/compact/aggregate/FieldAggregator.java
+++ b/paimon-core/src/main/java/org/apache/paimon/mergetree/compact/aggregate/FieldAggregator.java
@@ -95,9 +95,7 @@ public abstract class FieldAggregator implements Serializable {
                     case FieldNestedUpdateAgg.NAME:
                         fieldAggregator =
                                 createFieldNestedUpdateAgg(
-                                        fieldType,
-                                        options.fieldNestedUpdateAggNestedKey(field),
-                                        ignoreRetract);
+                                        fieldType, options.fieldNestedUpdateAggNestedKey(field));
                         break;
                     default:
                         throw new RuntimeException(
@@ -116,7 +114,7 @@ public abstract class FieldAggregator implements Serializable {
     }
 
     public static FieldAggregator createFieldNestedUpdateAgg(
-            DataType fieldType, List<String> nestedKey, boolean ignoreRetract) {
+            DataType fieldType, List<String> nestedKey) {
         if (nestedKey == null) {
             nestedKey = Collections.emptyList();
         }
@@ -126,8 +124,7 @@ public abstract class FieldAggregator implements Serializable {
         ArrayType arrayType = (ArrayType) fieldType;
         checkArgument(arrayType.getElementType() instanceof RowType, typeErrorMsg, fieldType);
 
-        FieldNestedUpdateAgg agg = new FieldNestedUpdateAgg(arrayType, nestedKey);
-        return ignoreRetract ? new FieldIgnoreRetractAgg(agg) : agg;
+        return new FieldNestedUpdateAgg(arrayType, nestedKey);
     }
 
     abstract String name();