You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2018/03/02 06:40:46 UTC

[GitHub] dongeforever commented on a change in pull request #224: [ROCKETMQ-367] Add logging component.

dongeforever commented on a change in pull request #224: [ROCKETMQ-367] Add logging component.
URL: https://github.com/apache/rocketmq/pull/224#discussion_r171773662
 
 

 ##########
 File path: logging/src/main/java/org/apache/rocketmq/logging/InternalLoggerFactory.java
 ##########
 @@ -0,0 +1,93 @@
+/*
 
 Review comment:
   It seems that , rocketmq's module including client,broker,namesrv, dose not adopt this InternalLoggerFactory.
   When and how this new module is integrated with the other modules.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services