You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@fluo.apache.org by mikewalch <gi...@git.apache.org> on 2017/04/03 21:42:48 UTC
[GitHub] incubator-fluo pull request #819: Fixes #818 - Old/new observers config exce...
GitHub user mikewalch opened a pull request:
https://github.com/apache/incubator-fluo/pull/819
Fixes #818 - Old/new observers config exception is causing ITs to fail
* Fixed bug and created unit test to verify
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mikewalch/incubator-fluo fluo-818
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-fluo/pull/819.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #819
----
commit e14bc03264a7fa4f4e8383b1884be0e45da3e671
Author: Mike Walch <mw...@apache.org>
Date: 2017-04-03T21:33:27Z
Fixes #818 - Old/new observers config exception is causing ITs to fail
* Fixed bug and created unit test to verify
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fluo pull request #819: Fixes #818 - Old/new observers config exce...
Posted by mikewalch <gi...@git.apache.org>.
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/incubator-fluo/pull/819#discussion_r109534591
--- Diff: modules/api/src/main/java/org/apache/fluo/api/config/FluoConfiguration.java ---
@@ -306,7 +306,8 @@ public int getWorkerThreads() {
while (iter.hasNext()) {
String key = iter.next();
- if (key.startsWith(FluoConfiguration.OBSERVER_PREFIX)) {
+ if (!key.startsWith(FluoConfiguration.OBSERVER_PROVIDER)
--- End diff --
fixed with latest commit
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fluo pull request #819: Fixes #818 - Old/new observers config exce...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-fluo/pull/819
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fluo pull request #819: Fixes #818 - Old/new observers config exce...
Posted by keith-turner <gi...@git.apache.org>.
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/incubator-fluo/pull/819#discussion_r109533581
--- Diff: modules/api/src/main/java/org/apache/fluo/api/config/FluoConfiguration.java ---
@@ -306,7 +306,8 @@ public int getWorkerThreads() {
while (iter.hasNext()) {
String key = iter.next();
- if (key.startsWith(FluoConfiguration.OBSERVER_PREFIX)) {
+ if (!key.startsWith(FluoConfiguration.OBSERVER_PROVIDER)
--- End diff --
could do not equals OBSERVER_PROVIDER
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---