You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2017/09/11 02:01:01 UTC

Review Request 62208: Improve performance of merging lists of policyEvaluators returned by Trie

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62208/
-----------------------------------------------------------

Review request for ranger, Madhan Neethiraj and Ramesh Mani.


Bugs: RANGER-1771
    https://issues.apache.org/jira/browse/RANGER-1771


Repository: ranger


Description
-------

For a multi-level resource, Ranger policy evaluation, to some extent, depends on how the policies are written, and how the a set of likely matching policies is evaluated. This is traced back to sub-optimal algorithm used for computing intersection of sets of matching policies for each resource level in the accessed resource. Improving this algorithm is required to a. improve performance of policy evaluation, and b. improve predictability of performance of policy evaluation.

Improvement and predictability of computing intersection of lists returned for each resource level is done by computing pairwise intersections of lists, and using the shortest list as the starting point.


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java a1002e8 


Diff: https://reviews.apache.org/r/62208/diff/1/


Testing
-------

Ran all unit tests successfully. Used ranger-perf-tester with hbase service to ensure improvement in policy evaluation performance, and its predictability by constructing accessed resource using different order of resource levels.


Thanks,

Abhay Kulkarni


Re: Review Request 62208: Improve performance of merging lists of policyEvaluators returned by Trie

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62208/#review185058
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Sept. 11, 2017, 2 a.m., Abhay Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62208/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2017, 2 a.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj and Ramesh Mani.
> 
> 
> Bugs: RANGER-1771
>     https://issues.apache.org/jira/browse/RANGER-1771
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> For a multi-level resource, Ranger policy evaluation, to some extent, depends on how the policies are written, and how the a set of likely matching policies is evaluated. This is traced back to sub-optimal algorithm used for computing intersection of sets of matching policies for each resource level in the accessed resource. Improving this algorithm is required to a. improve performance of policy evaluation, and b. improve predictability of performance of policy evaluation.
> 
> Improvement and predictability of computing intersection of lists returned for each resource level is done by computing pairwise intersections of lists, and using the shortest list as the starting point.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java a1002e8 
> 
> 
> Diff: https://reviews.apache.org/r/62208/diff/1/
> 
> 
> Testing
> -------
> 
> Ran all unit tests successfully. Used ranger-perf-tester with hbase service to ensure improvement in policy evaluation performance, and its predictability by constructing accessed resource using different order of resource levels.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>