You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Greg Stein <gs...@lyra.org> on 2001/06/26 11:27:19 UTC
Re: cvs commit: apr-util/buckets apr_buckets_mmap.c
On Tue, Jun 26, 2001 at 03:20:33AM -0000, jwoolley@apache.org wrote:
> jwoolley 01/06/25 20:20:32
>
> Modified: buckets apr_buckets_mmap.c
> Log:
> Get the prototype for memcpy().
>
> PS: I still question the copying of the mmap data into the pool in
> pool_setaside()... it seems to me that it's easy for that to accidentally
> copy a very large file in its entirety into memory. What am I missing?
Not missing anything.
setaside() should fix the lifetime. It shouldn't do anything more than that,
nor should it make "decisions" such as "copying into mem is best"
Cheers,
-g
--
Greg Stein, http://www.lyra.org/