You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@parquet.apache.org by "davidvoit (via GitHub)" <gi...@apache.org> on 2024/10/09 12:13:46 UTC
Re: [PR] GH-2990: Only call hsync() and hflush() on supported filesystems [parquet-java]
davidvoit commented on PR #2991:
URL: https://github.com/apache/parquet-java/pull/2991#issuecomment-2402151620
@steveloughran I'm a colleague of Christian and we worked together on this patch. If we add a own category this makes it just easier to filter out the message, but in the end hsync just don't make any sense for parquet and object storeage, or would you disagree?
I think the hasCapalipty route is the best one here. Object storage are always atomic so don't need hsync at all. For hdfs the code still does do the hsync as it has the capality. The warning still makes absolute sense for stuff like hbase, which should not be used as is together with an object storage driver, but parquet as is doesn't has this requirment, and works fine without hsync.
Sure we can wait for 2944 or if we should change something just let us now :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org