You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2024/08/24 04:43:33 UTC
[kudu-CR] [util] fine-grained versioning for diagnostic socket
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21722
Change subject: [util] fine-grained versioning for diagnostic socket
......................................................................
[util] fine-grained versioning for diagnostic socket
The motivation for this patch is to be able to build Kudu on
legacy Linux OS releases (kernel version < 3.3).
This patch is a follow-up to f15a1ca5476b256671c2369dd4d9faeccfee6b7c
and c0c44a8acd8d6366987af687d5665f751249a95a.
Change-Id: I4fad2ad5c5a177678f52bff080429568a20ac67c
---
M CMakeLists.txt
M src/kudu/rpc/acceptor_pool.cc
M src/kudu/rpc/rpc-test.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/net/diagnostic_socket.cc
5 files changed, 58 insertions(+), 31 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/21722/1
--
To view, visit http://gerrit.cloudera.org:8080/21722
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4fad2ad5c5a177678f52bff080429568a20ac67c
Gerrit-Change-Number: 21722
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [util] fine-grained versioning for diagnostic socket
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21722 )
Change subject: [util] fine-grained versioning for diagnostic socket
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21722
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fad2ad5c5a177678f52bff080429568a20ac67c
Gerrit-Change-Number: 21722
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Tue, 27 Aug 2024 01:50:45 +0000
Gerrit-HasComments: No
[kudu-CR] [util] fine-grained versioning for diagnostic socket
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21722 )
Change subject: [util] fine-grained versioning for diagnostic socket
......................................................................
Patch Set 2: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/451/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/21722
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fad2ad5c5a177678f52bff080429568a20ac67c
Gerrit-Change-Number: 21722
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Sat, 24 Aug 2024 06:53:15 +0000
Gerrit-HasComments: No
[kudu-CR] [util] fine-grained versioning for diagnostic socket
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21722 )
Change subject: [util] fine-grained versioning for diagnostic socket
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/21722/3/src/kudu/rpc/acceptor_pool.cc
File src/kudu/rpc/acceptor_pool.cc:
http://gerrit.cloudera.org:8080/#/c/21722/3/src/kudu/rpc/acceptor_pool.cc@97
PS3, Line 97: -1,
nit: alignment.
http://gerrit.cloudera.org:8080/#/c/21722/3/src/kudu/util/net/diagnostic_socket.cc
File src/kudu/util/net/diagnostic_socket.cc:
http://gerrit.cloudera.org:8080/#/c/21722/3/src/kudu/util/net/diagnostic_socket.cc@83
PS3, Line 83: Status DiagnosticSocket::Init() {
Is the DiagnosticSocket to be used in a cut mode or completely can not be used? If it can not be used, how about creating and using the object only when KUDU_HAS_DIAGNOSTIC_SOCKET is enabled like:
#if defined(KUDU_HAS_DIAGNOSTIC_SOCKET)
DiagnosticSocket diag_socket_;
#endif
--
To view, visit http://gerrit.cloudera.org:8080/21722
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fad2ad5c5a177678f52bff080429568a20ac67c
Gerrit-Change-Number: 21722
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Mon, 26 Aug 2024 06:53:47 +0000
Gerrit-HasComments: Yes
[kudu-CR] [util] fine-grained versioning for diagnostic socket
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Yingchun Lai, Yifan Zhang, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21722
to look at the new patch set (#2).
Change subject: [util] fine-grained versioning for diagnostic socket
......................................................................
[util] fine-grained versioning for diagnostic socket
The motivation for this patch is to be able to build Kudu on
legacy Linux OS releases (kernel version < 3.3).
This patch is a follow-up to f15a1ca5476b256671c2369dd4d9faeccfee6b7c
and c0c44a8acd8d6366987af687d5665f751249a95a.
Change-Id: I4fad2ad5c5a177678f52bff080429568a20ac67c
---
M CMakeLists.txt
M src/kudu/rpc/acceptor_pool.cc
M src/kudu/rpc/rpc-test.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/net/diagnostic_socket.cc
5 files changed, 58 insertions(+), 34 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/21722/2
--
To view, visit http://gerrit.cloudera.org:8080/21722
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4fad2ad5c5a177678f52bff080429568a20ac67c
Gerrit-Change-Number: 21722
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] [util] fine-grained versioning for diagnostic socket
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21722 )
Change subject: [util] fine-grained versioning for diagnostic socket
......................................................................
Patch Set 3: Verified+1
unrelated Java test failure (TSAN): a well-known flaky, see KUDU-2880
--
To view, visit http://gerrit.cloudera.org:8080/21722
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fad2ad5c5a177678f52bff080429568a20ac67c
Gerrit-Change-Number: 21722
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Sat, 24 Aug 2024 18:09:02 +0000
Gerrit-HasComments: No
[kudu-CR] [util] fine-grained versioning for diagnostic socket
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21722 )
Change subject: [util] fine-grained versioning for diagnostic socket
......................................................................
Patch Set 4:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/460/
--
To view, visit http://gerrit.cloudera.org:8080/21722
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fad2ad5c5a177678f52bff080429568a20ac67c
Gerrit-Change-Number: 21722
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Mon, 26 Aug 2024 19:34:13 +0000
Gerrit-HasComments: No
[kudu-CR] [util] fine-grained versioning for diagnostic socket
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Yingchun Lai, Yifan Zhang, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21722
to look at the new patch set (#3).
Change subject: [util] fine-grained versioning for diagnostic socket
......................................................................
[util] fine-grained versioning for diagnostic socket
The motivation for this patch is to be able to build Kudu on
legacy Linux OS releases (kernel version < 3.3).
This patch is a follow-up to f15a1ca5476b256671c2369dd4d9faeccfee6b7c
and c0c44a8acd8d6366987af687d5665f751249a95a.
Change-Id: I4fad2ad5c5a177678f52bff080429568a20ac67c
---
M CMakeLists.txt
M src/kudu/rpc/acceptor_pool.cc
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/rpc-test.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/net/diagnostic_socket.cc
6 files changed, 67 insertions(+), 43 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/21722/3
--
To view, visit http://gerrit.cloudera.org:8080/21722
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4fad2ad5c5a177678f52bff080429568a20ac67c
Gerrit-Change-Number: 21722
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] [util] fine-grained versioning for diagnostic socket
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21722 )
Change subject: [util] fine-grained versioning for diagnostic socket
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/21722/3/src/kudu/rpc/acceptor_pool.cc
File src/kudu/rpc/acceptor_pool.cc:
http://gerrit.cloudera.org:8080/#/c/21722/3/src/kudu/rpc/acceptor_pool.cc@97
PS3, Line 97: -1,
> nit: alignment.
Done
http://gerrit.cloudera.org:8080/#/c/21722/3/src/kudu/util/net/diagnostic_socket.cc
File src/kudu/util/net/diagnostic_socket.cc:
http://gerrit.cloudera.org:8080/#/c/21722/3/src/kudu/util/net/diagnostic_socket.cc@83
PS3, Line 83: Status DiagnosticSocket::Init() {
> Is the DiagnosticSocket to be used in a cut mode or completely can not be u
That's a good point.
The DiagnosticSocket isn't useful when the sock_diag netlink subsystem isn't available. There was a reason to chose the current approach instead of doing as you suggested, but I cannot recall it now.
I'd try to address this in a separate changelist since this isn't directly related to the scope of this particular patch.
--
To view, visit http://gerrit.cloudera.org:8080/21722
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fad2ad5c5a177678f52bff080429568a20ac67c
Gerrit-Change-Number: 21722
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Mon, 26 Aug 2024 19:34:00 +0000
Gerrit-HasComments: Yes
[kudu-CR] [util] fine-grained versioning for diagnostic socket
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [util] fine-grained versioning for diagnostic socket
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/21722
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I4fad2ad5c5a177678f52bff080429568a20ac67c
Gerrit-Change-Number: 21722
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] [util] fine-grained versioning for diagnostic socket
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Yingchun Lai, Yifan Zhang, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21722
to look at the new patch set (#4).
Change subject: [util] fine-grained versioning for diagnostic socket
......................................................................
[util] fine-grained versioning for diagnostic socket
The motivation for this patch is to be able to build Kudu on
legacy Linux OS releases (kernel version < 3.3).
This patch is a follow-up to f15a1ca5476b256671c2369dd4d9faeccfee6b7c
and c0c44a8acd8d6366987af687d5665f751249a95a.
Change-Id: I4fad2ad5c5a177678f52bff080429568a20ac67c
---
M CMakeLists.txt
M src/kudu/rpc/acceptor_pool.cc
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/rpc-test.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/net/diagnostic_socket.cc
6 files changed, 67 insertions(+), 43 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/21722/4
--
To view, visit http://gerrit.cloudera.org:8080/21722
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4fad2ad5c5a177678f52bff080429568a20ac67c
Gerrit-Change-Number: 21722
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] [util] fine-grained versioning for diagnostic socket
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21722 )
Change subject: [util] fine-grained versioning for diagnostic socket
......................................................................
Patch Set 4: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/460/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/21722
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fad2ad5c5a177678f52bff080429568a20ac67c
Gerrit-Change-Number: 21722
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Mon, 26 Aug 2024 20:49:37 +0000
Gerrit-HasComments: No
[kudu-CR] [util] fine-grained versioning for diagnostic socket
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21722 )
Change subject: [util] fine-grained versioning for diagnostic socket
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/449/
--
To view, visit http://gerrit.cloudera.org:8080/21722
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fad2ad5c5a177678f52bff080429568a20ac67c
Gerrit-Change-Number: 21722
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 24 Aug 2024 04:43:40 +0000
Gerrit-HasComments: No
[kudu-CR] [util] fine-grained versioning for diagnostic socket
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21722 )
Change subject: [util] fine-grained versioning for diagnostic socket
......................................................................
Patch Set 2:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/451/
--
To view, visit http://gerrit.cloudera.org:8080/21722
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fad2ad5c5a177678f52bff080429568a20ac67c
Gerrit-Change-Number: 21722
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Sat, 24 Aug 2024 05:42:10 +0000
Gerrit-HasComments: No
[kudu-CR] [util] fine-grained versioning for diagnostic socket
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21722 )
Change subject: [util] fine-grained versioning for diagnostic socket
......................................................................
Patch Set 4: Verified+1
unrelated test failures (known flaky tests)
--
To view, visit http://gerrit.cloudera.org:8080/21722
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fad2ad5c5a177678f52bff080429568a20ac67c
Gerrit-Change-Number: 21722
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Mon, 26 Aug 2024 23:33:12 +0000
Gerrit-HasComments: No
[kudu-CR] [util] fine-grained versioning for diagnostic socket
Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21722 )
Change subject: [util] fine-grained versioning for diagnostic socket
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/21722
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fad2ad5c5a177678f52bff080429568a20ac67c
Gerrit-Change-Number: 21722
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Mon, 26 Aug 2024 23:40:09 +0000
Gerrit-HasComments: No
[kudu-CR] [util] fine-grained versioning for diagnostic socket
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21722 )
Change subject: [util] fine-grained versioning for diagnostic socket
......................................................................
Patch Set 1:
Build Aborted
http://jenkins.kudu.apache.org/job/pre_commit/449/ : ABORTED
--
To view, visit http://gerrit.cloudera.org:8080/21722
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fad2ad5c5a177678f52bff080429568a20ac67c
Gerrit-Change-Number: 21722
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Sat, 24 Aug 2024 05:42:04 +0000
Gerrit-HasComments: No
[kudu-CR] [util] fine-grained versioning for diagnostic socket
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21722 )
Change subject: [util] fine-grained versioning for diagnostic socket
......................................................................
Patch Set 3:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/452/
--
To view, visit http://gerrit.cloudera.org:8080/21722
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fad2ad5c5a177678f52bff080429568a20ac67c
Gerrit-Change-Number: 21722
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Sat, 24 Aug 2024 06:59:25 +0000
Gerrit-HasComments: No
[kudu-CR] [util] fine-grained versioning for diagnostic socket
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [util] fine-grained versioning for diagnostic socket
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/21722
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I4fad2ad5c5a177678f52bff080429568a20ac67c
Gerrit-Change-Number: 21722
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] [util] fine-grained versioning for diagnostic socket
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Abhishek Chennaka from this change. ( http://gerrit.cloudera.org:8080/21722 )
Change subject: [util] fine-grained versioning for diagnostic socket
......................................................................
Removed reviewer Abhishek Chennaka.
--
To view, visit http://gerrit.cloudera.org:8080/21722
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I4fad2ad5c5a177678f52bff080429568a20ac67c
Gerrit-Change-Number: 21722
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] [util] fine-grained versioning for diagnostic socket
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21722 )
Change subject: [util] fine-grained versioning for diagnostic socket
......................................................................
Patch Set 3: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/452/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/21722
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fad2ad5c5a177678f52bff080429568a20ac67c
Gerrit-Change-Number: 21722
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Sat, 24 Aug 2024 08:03:31 +0000
Gerrit-HasComments: No
[kudu-CR] [util] fine-grained versioning for diagnostic socket
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21722 )
Change subject: [util] fine-grained versioning for diagnostic socket
......................................................................
[util] fine-grained versioning for diagnostic socket
The motivation for this patch is to be able to build Kudu on
legacy Linux OS releases (kernel version < 3.3).
This patch is a follow-up to f15a1ca5476b256671c2369dd4d9faeccfee6b7c
and c0c44a8acd8d6366987af687d5665f751249a95a.
Change-Id: I4fad2ad5c5a177678f52bff080429568a20ac67c
Reviewed-on: http://gerrit.cloudera.org:8080/21722
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Mahesh Reddy <mr...@cloudera.com>
Reviewed-by: Yingchun Lai <la...@apache.org>
---
M CMakeLists.txt
M src/kudu/rpc/acceptor_pool.cc
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/rpc-test.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/net/diagnostic_socket.cc
6 files changed, 67 insertions(+), 43 deletions(-)
Approvals:
Alexey Serbin: Verified
Mahesh Reddy: Looks good to me, but someone else must approve
Yingchun Lai: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/21722
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4fad2ad5c5a177678f52bff080429568a20ac67c
Gerrit-Change-Number: 21722
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>