[jira] [Commented] (FLINK-10828) Enforce that all TypeSerializers are tested through SerializerTestBase

["Chesnay Schepler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-10828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680967#comment-16680967 ] 

Chesnay Schepler commented on FLINK-10828:
------------------------------------------

Do you have a suggestion on how to implement this?

For the first part we could _probably_ run over all files, search for {{X extends TypeSerializer/SomeOtherClass}}, and expect a test {{XTest}} in the same module&package that extends {{SerializerTestBase/SomeOtherTestBase}}.

No idea about the second part though.

> Enforce that all TypeSerializers are tested through SerializerTestBase
> ----------------------------------------------------------------------
>
>                 Key: FLINK-10828
>                 URL: https://issues.apache.org/jira/browse/FLINK-10828
>             Project: Flink
>          Issue Type: Test
>          Components: Tests
>            Reporter: Stefan Richter
>            Priority: Major
>
> As pointed out in FLINK-10827, type serializers are a common source of bugs and we should try to enforce that every type serializer (that is not exclusive to tests) is tested at least through a test that extends the {{SerializerTestBase}}. We should also check that the tests of composite serializers use inner serializers that are stateful and require proper duplication, or else the tests can pass even if inner serializers are not properly duplicated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)