You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@bookkeeper.apache.org by "Sijie Guo (JIRA)" <ji...@apache.org> on 2016/01/13 09:52:40 UTC

[jira] [Commented] (BOOKKEEPER-877) Script for generating patch for reviews

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15095837#comment-15095837 ] 

Sijie Guo commented on BOOKKEEPER-877:
--------------------------------------

[~jiannan] that's probably fine. because the binary changes are not reviewable. I would stick to git diff right now. open to change it later. does that make sense to you?

> Script for generating patch for reviews
> ---------------------------------------
>
>                 Key: BOOKKEEPER-877
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-877
>             Project: Bookkeeper
>          Issue Type: Improvement
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>         Attachments: BOOKKEEPER-877.patch, BOOKKEEPER-877_2015-11-12_00:26:23.patch, BOOKKEEPER-877_2015-11-12_00:28:08.patch, BOOKKEEPER-877_2015-11-12_00:52:03.patch
>
>
> It would be good to have a script to generate patch for reviews.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)