You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/04/24 00:40:53 UTC

[GitHub] [arrow] sunchao edited a comment on pull request #6949: ARROW-7681: [Rust] Explicitly seeking a BufReader will discard the internal buffer (2)

sunchao edited a comment on pull request #6949:
URL: https://github.com/apache/arrow/pull/6949#issuecomment-618740530


   Yes I think it is beneficial to avoid dropping buffers with `seek`, although it will be nice if the `seek_relative` will be stabilized soon so we can just use that.
   
   > Also, I'm not sure why a Mutex was used here. Do we agree that Refcell is better as the whole reader is not thread safe, right ?
   
   [Originally](https://github.com/sunchao/parquet-rs/pull/49) we designed it this way so that we can concurrently read multiple column chunks after obtaining file handle from a single row group.  Since the file handle is shared between these we wanted to provide thread safety on top of it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org