You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/06/16 07:53:35 UTC

[GitHub] [hive] pvary commented on a diff in pull request #3365: HIVE-26265: Option to filter out Txn events during replication.

pvary commented on code in PR #3365:
URL: https://github.com/apache/hive/pull/3365#discussion_r898801022


##########
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/events/AbortTxnHandler.java:
##########
@@ -39,6 +48,19 @@ public void handle(Context withinContext) throws Exception {
     if (!ReplUtils.includeAcidTableInDump(withinContext.hiveConf)) {
       return;
     }
+
+     if (ReplUtils.filterTransactionOperations(withinContext.hiveConf)) {
+       String contextDbName = StringUtils.normalizeIdentifier(withinContext.replScope.getDbName());
+       GetTxnWriteIdsRequest request = new GetTxnWriteIdsRequest(eventMessage.getTxnId());
+       request.setDbName(contextDbName);
+       GetTxnWriteIdsResponse response = withinContext.db.getMSC().getTxnWriteIds(request);

Review Comment:
   Could we do this without calling the metastore?
   All of requested writeIds should be available during the compilation phase



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org