You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/03/17 23:25:04 UTC
Review Request 19324: Initialize the metrics system.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19324/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Vinod Kone.
Repository: mesos-git
Description
-------
see summary
Diffs
-----
src/master/master.cpp 6da776699beb6f449e8160dcb6a125d94c1ab437
src/slave/slave.cpp d8d3e0fa54972201d72b2650ec0ba922a4912d54
Diff: https://reviews.apache.org/r/19324/diff/
Testing
-------
built, ran 'local', checked endpoint.
Thanks,
Dominic Hamon
Re: Review Request 19324: Initialize the metrics system.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19324/#review37507
-----------------------------------------------------------
src/slave/slave.cpp
<https://reviews.apache.org/r/19324/#comment69052>
Is it safe/ok for multiple master libprocesses in the same unix process (e.g., tests) to do this initialization multiple times? Why not just initialize metrics as part of libprocess initialize?
- Vinod Kone
On March 17, 2014, 11:47 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19324/
> -----------------------------------------------------------
>
> (Updated March 17, 2014, 11:47 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-1036
> https://issues.apache.org/jira/browse/MESOS-1036
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/master/master.cpp 6da776699beb6f449e8160dcb6a125d94c1ab437
> src/slave/slave.cpp d8d3e0fa54972201d72b2650ec0ba922a4912d54
>
> Diff: https://reviews.apache.org/r/19324/diff/
>
>
> Testing
> -------
>
> built, ran 'local', checked endpoint.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 19324: Initialize the metrics system.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19324/
-----------------------------------------------------------
(Updated March 17, 2014, 4:47 p.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Bugs: MESOS-1036
https://issues.apache.org/jira/browse/MESOS-1036
Repository: mesos-git
Description
-------
see summary
Diffs
-----
src/master/master.cpp 6da776699beb6f449e8160dcb6a125d94c1ab437
src/slave/slave.cpp d8d3e0fa54972201d72b2650ec0ba922a4912d54
Diff: https://reviews.apache.org/r/19324/diff/
Testing
-------
built, ran 'local', checked endpoint.
Thanks,
Dominic Hamon
Re: Review Request 19324: Initialize the metrics system.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19324/#review37505
-----------------------------------------------------------
Bad patch!
Reviews applied: [19324]
Failed command: make -j3 check GTEST_FILTER='' >/dev/null
Error:
ev.c:1531:31: warning: 'ev_default_loop_ptr' initialized and declared 'extern' [enabled by default]
ev.c: In function 'evpipe_write':
ev.c:2160:17: warning: ignoring return value of 'write', declared with attribute warn_unused_result [-Wunused-result]
ev.c:2172:17: warning: ignoring return value of 'write', declared with attribute warn_unused_result [-Wunused-result]
ev.c: In function 'pipecb':
ev.c:2193:16: warning: ignoring return value of 'read', declared with attribute warn_unused_result [-Wunused-result]
ev.c:2207:16: warning: ignoring return value of 'read', declared with attribute warn_unused_result [-Wunused-result]
In file included from /usr/include/c++/4.6/ext/hash_set:61:0,
from src/glog/stl_logging.h:54,
from src/stl_logging_unittest.cc:34:
/usr/include/c++/4.6/backward/backward_warning.h:33:2: warning: #warning This file includes at least one deprecated or antiquated header which may be removed without further notice at a future date. Please use a non-deprecated interface with equivalent functionality instead. For a listing of replacement headers and interfaces, consult the file backward_warning.h. To disable this warning use -Wno-deprecated. [-Wcpp]
In file included from src/utilities.h:73:0,
from src/googletest.h:38,
from src/stl_logging_unittest.cc:48:
src/base/mutex.h:137:0: warning: "_XOPEN_SOURCE" redefined [enabled by default]
/usr/include/features.h:166:0: note: this is the location of the previous definition
warning: no files found matching 'Makefile' under directory 'docs'
warning: no files found matching 'indexsidebar.html' under directory 'docs'
zip_safe flag not set; analyzing archive contents...
master/master.cpp:33:39: fatal error: process/metrics/metrics.hpp: No such file or directory
compilation terminated.
make[2]: *** [master/libmesos_no_3rdparty_la-master.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [check] Error 2
make: *** [check-recursive] Error 1
- Mesos ReviewBot
On March 17, 2014, 10:25 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19324/
> -----------------------------------------------------------
>
> (Updated March 17, 2014, 10:25 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-1036
> https://issues.apache.org/jira/browse/MESOS-1036
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/master/master.cpp 6da776699beb6f449e8160dcb6a125d94c1ab437
> src/slave/slave.cpp d8d3e0fa54972201d72b2650ec0ba922a4912d54
>
> Diff: https://reviews.apache.org/r/19324/diff/
>
>
> Testing
> -------
>
> built, ran 'local', checked endpoint.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 19324: Initialize the metrics system.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19324/
-----------------------------------------------------------
(Updated March 17, 2014, 3:25 p.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Bugs: MESOS-1036
https://issues.apache.org/jira/browse/MESOS-1036
Repository: mesos-git
Description
-------
see summary
Diffs
-----
src/master/master.cpp 6da776699beb6f449e8160dcb6a125d94c1ab437
src/slave/slave.cpp d8d3e0fa54972201d72b2650ec0ba922a4912d54
Diff: https://reviews.apache.org/r/19324/diff/
Testing
-------
built, ran 'local', checked endpoint.
Thanks,
Dominic Hamon