You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/02/12 04:21:02 UTC

[GitHub] sijie commented on a change in pull request #1130: handle zookeeper session expire in zk ledger manager

sijie commented on a change in pull request #1130: handle zookeeper session expire in zk ledger manager
URL: https://github.com/apache/bookkeeper/pull/1130#discussion_r167467345
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java
 ##########
 @@ -52,6 +53,7 @@
  *
  * <p>It provides parsing and serialization methods of such metadata.
  */
+@EqualsAndHashCode
 
 Review comment:
   this is to implement `equals`. because in the tests, I need to assert if two ledger metadata equal to each other.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services