You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/07/06 08:49:59 UTC

[GitHub] [incubator-echarts] plainheart edited a comment on pull request #12484: feat: bar race

plainheart edited a comment on pull request #12484:
URL: https://github.com/apache/incubator-echarts/pull/12484#issuecomment-654088597


   @Ovilia Hi, thank you for your excellent work for bar race. Here I'd like to give some feedback for this new feature, please feel free to check and evaluate it.
   Normally, if the value of bar doesn't change, the value of its label should not change and if changed, it should count from its previous newest value, but in fact, the value of bar label will always count from 0 when updating, just like the screenshot below:
   
   ![unexpected](https://user-images.githubusercontent.com/26999792/86570584-bb86c400-bfa2-11ea-89ac-390ffd97b4f6.gif)
   
   What I think it's expected is like this:
   
   ![expected](https://user-images.githubusercontent.com/26999792/86570612-c5a8c280-bfa2-11ea-8373-c198629a9814.gif)
   
   That is,
   1). The label of bar has no need to recount from 0 if its value has no change.
   2). If its value changed, it should recount from its previous value, like the screenshot above.
   
   What do you think of these?
   
   EDITED: I saw it looks like working well in the screenshot you provided in PR description.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org