[GitHub] [nifi] markap14 commented on pull request #5094: NIFI-8195: add default connection settings to process group configura…

[GitBox <gi...@apache.org>]

markap14 commented on pull request #5094:
URL: https://github.com/apache/nifi/pull/5094#issuecomment-867878823


   Thanks for the contribution and thanks for spending the time to review @mattyb149 . But I think this PR is problematic.
   The Jira spells this out as adding a default backpressure at the Process Group level. I don't think this is necessary, but I don't necessarily have a problem with it. However, the PR doesn't appear to update VersionedProcessGroup, which means that after it's been pushed to the registry and then pulled out again, the newly created one will not function like the old one did - it won't have the default settings. That needs to be addressed.
   
   However, more concerning is the introduction of the default FlowFile Expiration. We should not be introducing FlowFile Expiration without the user explicitly setting it. This was discussed at length previously in https://github.com/apache/nifi/pull/4800
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org