You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/04/12 19:08:41 UTC

[GitHub] [accumulo] keith-turner opened a new issue #2011: Ensure no external compaction metadata propagates when a tablet splits/merges

keith-turner opened a new issue #2011:
URL: https://github.com/apache/accumulo/issues/2011


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo] dlmarion closed issue #2011: Ensure no external compaction metadata propagates when a tablet splits/merges

Posted by GitBox <gi...@apache.org>.
dlmarion closed issue #2011:
URL: https://github.com/apache/accumulo/issues/2011


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo] keith-turner commented on issue #2011: Ensure no external compaction metadata propagates when a tablet splits/merges

Posted by GitBox <gi...@apache.org>.
keith-turner commented on issue #2011:
URL: https://github.com/apache/accumulo/issues/2011#issuecomment-828067149


   @dlmarion  I made a few tweaks to you new ITs in b7283aa5853aa62fc30e082d170536c2c810f8c0 that test the changes in c478645f984ca0eee8533073d545a20ced29a77d.  If those look good I think we can close this.   One thing I did was make sure the set of ext compaction ids differ before and after split/merge.  Thinking that new ext compaction ids could possibly show up after the split/merge for the new tablet.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo] dlmarion commented on issue #2011: Ensure no external compaction metadata propagates when a tablet splits/merges

Posted by GitBox <gi...@apache.org>.
dlmarion commented on issue #2011:
URL: https://github.com/apache/accumulo/issues/2011#issuecomment-828399555


   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo] milleruntime commented on issue #2011: Ensure no external compaction metadata propagates when a tablet splits/merges

Posted by GitBox <gi...@apache.org>.
milleruntime commented on issue #2011:
URL: https://github.com/apache/accumulo/issues/2011#issuecomment-818705479


   As a reference for others, here is the point in the code where we cancel compactions. 
   It is called while closing the Tablet in `initiateClose(true)` during `Tablet.split()`:
   https://github.com/apache/accumulo/blob/9b504121dd69bf033dced56adb55d727b0eafdc4/server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java#L1204


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org