You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by jun aoki <ju...@gmail.com> on 2014/10/05 09:27:19 UTC
Re: Review Request 26334: Summary:AMBARI-7442 ServiceCheck cannot be
run if there is only one stack definition
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26334/
-----------------------------------------------------------
(Updated Oct. 5, 2014, 7:27 a.m.)
Review request for Ambari and Sid Wagle.
Changes
-------
Applied Sid's advice from https://reviews.apache.org/r/26057/diff/# (I made a new reviewboard as the original one was created by someone else)
Both all HDP stack versions case and only one single case (HDP2.0.6) works.
Summary (updated)
-----------------
Summary:AMBARI-7442 ServiceCheck cannot be run if there is only one stack definition
Bugs: AMBARI-7442
https://issues.apache.org/jira/browse/AMBARI-7442
Repository: ambari
Description (updated)
-------
Summary:AMBARI-7442 ServiceCheck cannot be run if there is only one stack definition
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java 1c3f9a7
ambari-server/src/test/java/org/apache/ambari/server/api/util/StackExtensionHelperTest.java 7262dfb
ambari-server/src/test/resources/single_stack/ABC/1.0.0/metainfo.xml PRE-CREATION
ambari-server/src/test/resources/single_stack/ABC/1.0.0/services/HDFS/metainfo.xml PRE-CREATION
Diff: https://reviews.apache.org/r/26334/diff/
Testing
-------
Thanks,
jun aoki
Re: Review Request 26334: Summary:AMBARI-7442 ServiceCheck cannot be
run if there is only one stack definition
Posted by jun aoki <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26334/#review55471
-----------------------------------------------------------
Sid, i got rid of the iteration of parentes of every services as you advised here https://reviews.apache.org/r/26057/
I did it because the original code did. ( https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java#L494 )
- jun aoki
On Oct. 5, 2014, 7:27 a.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26334/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2014, 7:27 a.m.)
>
>
> Review request for Ambari and Sid Wagle.
>
>
> Bugs: AMBARI-7442
> https://issues.apache.org/jira/browse/AMBARI-7442
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Summary:AMBARI-7442 ServiceCheck cannot be run if there is only one stack definition
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java 1c3f9a7
> ambari-server/src/test/java/org/apache/ambari/server/api/util/StackExtensionHelperTest.java 7262dfb
> ambari-server/src/test/resources/single_stack/ABC/1.0.0/metainfo.xml PRE-CREATION
> ambari-server/src/test/resources/single_stack/ABC/1.0.0/services/HDFS/metainfo.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26334/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 26334: Summary:AMBARI-7442 ServiceCheck cannot be
run if there is only one stack definition
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26334/#review55475
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On Oct. 5, 2014, 7:27 a.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26334/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2014, 7:27 a.m.)
>
>
> Review request for Ambari and Sid Wagle.
>
>
> Bugs: AMBARI-7442
> https://issues.apache.org/jira/browse/AMBARI-7442
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Summary:AMBARI-7442 ServiceCheck cannot be run if there is only one stack definition
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java 1c3f9a7
> ambari-server/src/test/java/org/apache/ambari/server/api/util/StackExtensionHelperTest.java 7262dfb
> ambari-server/src/test/resources/single_stack/ABC/1.0.0/metainfo.xml PRE-CREATION
> ambari-server/src/test/resources/single_stack/ABC/1.0.0/services/HDFS/metainfo.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26334/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 26334: Summary:AMBARI-7442 ServiceCheck cannot be
run if there is only one stack definition
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26334/#review55476
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Oct. 5, 2014, 7:27 a.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26334/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2014, 7:27 a.m.)
>
>
> Review request for Ambari and Sid Wagle.
>
>
> Bugs: AMBARI-7442
> https://issues.apache.org/jira/browse/AMBARI-7442
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Summary:AMBARI-7442 ServiceCheck cannot be run if there is only one stack definition
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java 1c3f9a7
> ambari-server/src/test/java/org/apache/ambari/server/api/util/StackExtensionHelperTest.java 7262dfb
> ambari-server/src/test/resources/single_stack/ABC/1.0.0/metainfo.xml PRE-CREATION
> ambari-server/src/test/resources/single_stack/ABC/1.0.0/services/HDFS/metainfo.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26334/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> jun aoki
>
>