[GitHub] [iceberg] aokolnychyi commented on a change in pull request #2600: Refactor of RewriteDataFiles and BinPackStrategy

[GitBox <gi...@apache.org>]

aokolnychyi commented on a change in pull request #2600:
URL: https://github.com/apache/iceberg/pull/2600#discussion_r633898217



##########
File path: core/src/main/java/org/apache/iceberg/actions/BinPackStrategy.java
##########
@@ -45,20 +44,12 @@
 abstract class BinPackStrategy implements RewriteStrategy {
 
   /**
-   * Minimum number of files that need to be in a file group to be considered
-   * for rewriting. This is considered in conjunction with {@link MIN_OUTPUT_FILES}, both
-   * conditions must pass to consider a group of files to be rewritten.
+   * The minimum number of files that need to be in a file group for it to be considered for

Review comment:
       Looks like we have to update the Javadoc for the class as well.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org