You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by "waterWang (via GitHub)" <gi...@apache.org> on 2026/08/10 08:41:13 UTC
[PR] fix(dataZoom): keep slider handle label visible when mouse stays over handle after drag end [echarts]
waterWang opened a new pull request, #21722:
URL: https://github.com/apache/echarts/pull/21722
Fixes #20178
## Problem
When dragging a dataZoom slider handle and releasing the mouse **without moving it away** (i.e. the mouse stays over the handle), the handle's label disappears even though the pointer is still over the handle.
## Root cause
During a drag, the handle's `onmouseout` can fire (the pointer briefly leaves the handle hit area as it moves), which sets `SliderZoomView._isOverDataInfoTriggerArea = false`. On `dragend`, `_onDragEnd()` checks that flag and, because it is `false`, calls `_showDataInfo(false)` which hides the label — even though the mouse is still sitting over the handle.
## Fix
Accept the `dragend` event in `_onDragEnd(e)`. When the flag is `false`, only hide the label if the drag did **not** end on a handle or the move zone. If the drag released over a handle / move zone, keep the label visible so it matches the "mouse is still over the handle" expectation.
This also forwards the event from `_onActualMoveZoneDragEnd` so the move-zone drag path behaves the same way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix(dataZoom): keep slider handle label visible when mouse stays over handle after drag end [echarts]
Posted by "echarts-bot[bot] (via GitHub)" <gi...@apache.org>.
echarts-bot[bot] commented on PR #21722:
URL: https://github.com/apache/echarts/pull/21722#issuecomment-5237878369
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
Please **DO NOT** commit the files in [dist](https://github.com/apache/echarts/tree/master/dist), [i18n](https://github.com/apache/echarts/tree/master/i18n), and [ssr/client/dist](https://github.com/apache/echarts/tree/master/ssr/client/dist) folders in a non-release pull request. These folders are for release use only.
To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: `PR: doc ready`, `PR: awaiting doc`, `PR: doc unchanged`
This message is shown because the PR description doesn't contain the document related template.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org