[GitHub] [airflow] gmontanola commented on a change in pull request #10437: Fixes MySQLToS3 float to int conversion

[GitBox <gi...@apache.org>]

gmontanola commented on a change in pull request #10437:
URL: https://github.com/apache/airflow/pull/10437#discussion_r504240367



##########
File path: airflow/providers/amazon/aws/transfers/mysql_to_s3.py
##########
@@ -105,7 +105,8 @@ def _fix_int_dtypes(self, df):
                 notna_series = df[col].dropna().values
                 if np.isclose(notna_series, notna_series.astype(int)).all():
                     # set to dtype that retains integers and supports NaNs
-                    df[col] = np.where(df[col].isnull(), None, df[col]).astype(pd.Int64Dtype)
+                    df[col] = np.where(df[col].isnull(), None, df[col])
+                    df[col] = df[col].astype(pd.Int64Dtype())

Review comment:
       I totally forgot this. Well, I guess adding this test should be pretty straight forward. I'll try to add this this week. Are you willing to add this by yourself or found a better a way to fix the problem?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org