[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #3125: [Improve][Connector-V2-kafka] Support for dynamic discover topic & partition in streaming mode

[GitBox <gi...@apache.org>]

Hisoka-X commented on code in PR #3125:
URL: https://github.com/apache/incubator-seatunnel/pull/3125#discussion_r997673454


##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSourceSplitEnumerator.java:
##########
@@ -66,13 +69,42 @@ public class KafkaSourceSplitEnumerator implements SourceSplitEnumerator<KafkaSo
         this(metadata, context);
     }
 
+    KafkaSourceSplitEnumerator(ConsumerMetadata metadata, Context<KafkaSourceSplit> context,
+                               long discoveryIntervalMillis) {
+        this(metadata, context);
+        this.discoveryIntervalMillis = discoveryIntervalMillis;
+    }
+
     @Override
     public void open() {
         this.adminClient = initAdminClient(this.metadata.getProperties());
+        ParallelSource parallelSource = context.getParallelSource();

Review Comment:
   It's not right the connector to use translation module class. You can use `ScheduledThreadPoolExecutor` to execute topic find with fixed rate. Then close `ScheduledThreadPoolExecutor` when `KafkaSourceSplitEnumerator`  closed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org