You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ross Allen <re...@gmail.com> on 2013/07/05 21:33:38 UTC
Review Request 12279: Remove 60px padding for mobile devices
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12279/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
Mobile devices 979px and narrower use a statically positioned navbar and therefore need no padding for the <body>.
See http://twitter.github.io/bootstrap/scaffolding.html#responsive
Diffs
-----
src/webui/master/static/mesos.css 255219f09b1ec9cecd96bf4517c7e184264810b5
Diff: https://reviews.apache.org/r/12279/diff/
Testing
-------
Thanks,
Ross Allen
Re: Review Request 12279: Remove 60px padding for mobile devices
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12279/#review22819
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On July 5, 2013, 10:12 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12279/
> -----------------------------------------------------------
>
> (Updated July 5, 2013, 10:12 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Mobile devices 979px and narrower use a statically positioned navbar and therefore need no padding for the <body>.
>
> See http://twitter.github.io/bootstrap/scaffolding.html#responsive
>
>
> Diffs
> -----
>
> src/webui/master/static/mesos.css 255219f09b1ec9cecd96bf4517c7e184264810b5
>
> Diff: https://reviews.apache.org/r/12279/diff/
>
>
> Testing
> -------
>
> Viewed site in Chrome + Firefox with width <980px.
>
>
> File Attachments
> ----------------
>
> Chrome, pre-commit
> https://reviews.apache.org/media/uploaded/files/2013/07/05/Screen_Shot_2013-07-05_at_3.08.11_PM.png
> Firefox, pre-commit
> https://reviews.apache.org/media/uploaded/files/2013/07/05/Screen_Shot_2013-07-05_at_3.08.41_PM.png
> Chrome, post-commit
> https://reviews.apache.org/media/uploaded/files/2013/07/05/Screen_Shot_2013-07-05_at_3.08.58_PM.png
> Firefox, post-commit
> https://reviews.apache.org/media/uploaded/files/2013/07/05/Screen_Shot_2013-07-05_at_3.08.55_PM.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12279: Remove 60px padding for mobile devices
Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12279/#review22796
-----------------------------------------------------------
Ship it!
Ship It!
- Brenden Matthews
On July 5, 2013, 10:12 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12279/
> -----------------------------------------------------------
>
> (Updated July 5, 2013, 10:12 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Mobile devices 979px and narrower use a statically positioned navbar and therefore need no padding for the <body>.
>
> See http://twitter.github.io/bootstrap/scaffolding.html#responsive
>
>
> Diffs
> -----
>
> src/webui/master/static/mesos.css 255219f09b1ec9cecd96bf4517c7e184264810b5
>
> Diff: https://reviews.apache.org/r/12279/diff/
>
>
> Testing
> -------
>
> Viewed site in Chrome + Firefox with width <980px.
>
>
> File Attachments
> ----------------
>
> Chrome, pre-commit
> https://reviews.apache.org/media/uploaded/files/2013/07/05/Screen_Shot_2013-07-05_at_3.08.11_PM.png
> Firefox, pre-commit
> https://reviews.apache.org/media/uploaded/files/2013/07/05/Screen_Shot_2013-07-05_at_3.08.41_PM.png
> Chrome, post-commit
> https://reviews.apache.org/media/uploaded/files/2013/07/05/Screen_Shot_2013-07-05_at_3.08.58_PM.png
> Firefox, post-commit
> https://reviews.apache.org/media/uploaded/files/2013/07/05/Screen_Shot_2013-07-05_at_3.08.55_PM.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12279: Remove 60px padding for mobile devices
Posted by Ross Allen <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12279/
-----------------------------------------------------------
(Updated July 5, 2013, 10:12 p.m.)
Review request for mesos.
Repository: mesos
Description
-------
Mobile devices 979px and narrower use a statically positioned navbar and therefore need no padding for the <body>.
See http://twitter.github.io/bootstrap/scaffolding.html#responsive
Diffs
-----
src/webui/master/static/mesos.css 255219f09b1ec9cecd96bf4517c7e184264810b5
Diff: https://reviews.apache.org/r/12279/diff/
Testing (updated)
-------
Viewed site in Chrome + Firefox with width <980px.
File Attachments
----------------
Chrome, pre-commit
https://reviews.apache.org/media/uploaded/files/2013/07/05/Screen_Shot_2013-07-05_at_3.08.11_PM.png
Firefox, pre-commit
https://reviews.apache.org/media/uploaded/files/2013/07/05/Screen_Shot_2013-07-05_at_3.08.41_PM.png
Chrome, post-commit
https://reviews.apache.org/media/uploaded/files/2013/07/05/Screen_Shot_2013-07-05_at_3.08.58_PM.png
Firefox, post-commit
https://reviews.apache.org/media/uploaded/files/2013/07/05/Screen_Shot_2013-07-05_at_3.08.55_PM.png
Thanks,
Ross Allen
Re: Review Request 12279: Remove 60px padding for mobile devices
Posted by Ross Allen <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12279/
-----------------------------------------------------------
(Updated July 5, 2013, 10:11 p.m.)
Review request for mesos.
Changes
-------
Added pre/post commit screenshots of <980px dimensions to trigger style change.
Repository: mesos
Description
-------
Mobile devices 979px and narrower use a statically positioned navbar and therefore need no padding for the <body>.
See http://twitter.github.io/bootstrap/scaffolding.html#responsive
Diffs
-----
src/webui/master/static/mesos.css 255219f09b1ec9cecd96bf4517c7e184264810b5
Diff: https://reviews.apache.org/r/12279/diff/
Testing
-------
File Attachments (updated)
----------------
Chrome, pre-commit
https://reviews.apache.org/media/uploaded/files/2013/07/05/Screen_Shot_2013-07-05_at_3.08.11_PM.png
Firefox, pre-commit
https://reviews.apache.org/media/uploaded/files/2013/07/05/Screen_Shot_2013-07-05_at_3.08.41_PM.png
Chrome, post-commit
https://reviews.apache.org/media/uploaded/files/2013/07/05/Screen_Shot_2013-07-05_at_3.08.58_PM.png
Firefox, post-commit
https://reviews.apache.org/media/uploaded/files/2013/07/05/Screen_Shot_2013-07-05_at_3.08.55_PM.png
Thanks,
Ross Allen
Re: Review Request 12279: Remove 60px padding for mobile devices
Posted by Ross Allen <re...@gmail.com>.
> On July 5, 2013, 10:02 p.m., Brenden Matthews wrote:
> > Testing done?
Added screenshots. Tested in Firefox + Chrome.
- Ross
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12279/#review22794
-----------------------------------------------------------
On July 5, 2013, 10:12 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12279/
> -----------------------------------------------------------
>
> (Updated July 5, 2013, 10:12 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Mobile devices 979px and narrower use a statically positioned navbar and therefore need no padding for the <body>.
>
> See http://twitter.github.io/bootstrap/scaffolding.html#responsive
>
>
> Diffs
> -----
>
> src/webui/master/static/mesos.css 255219f09b1ec9cecd96bf4517c7e184264810b5
>
> Diff: https://reviews.apache.org/r/12279/diff/
>
>
> Testing
> -------
>
> Viewed site in Chrome + Firefox with width <980px.
>
>
> File Attachments
> ----------------
>
> Chrome, pre-commit
> https://reviews.apache.org/media/uploaded/files/2013/07/05/Screen_Shot_2013-07-05_at_3.08.11_PM.png
> Firefox, pre-commit
> https://reviews.apache.org/media/uploaded/files/2013/07/05/Screen_Shot_2013-07-05_at_3.08.41_PM.png
> Chrome, post-commit
> https://reviews.apache.org/media/uploaded/files/2013/07/05/Screen_Shot_2013-07-05_at_3.08.58_PM.png
> Firefox, post-commit
> https://reviews.apache.org/media/uploaded/files/2013/07/05/Screen_Shot_2013-07-05_at_3.08.55_PM.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12279: Remove 60px padding for mobile devices
Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12279/#review22794
-----------------------------------------------------------
Testing done?
- Brenden Matthews
On July 5, 2013, 7:33 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12279/
> -----------------------------------------------------------
>
> (Updated July 5, 2013, 7:33 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Mobile devices 979px and narrower use a statically positioned navbar and therefore need no padding for the <body>.
>
> See http://twitter.github.io/bootstrap/scaffolding.html#responsive
>
>
> Diffs
> -----
>
> src/webui/master/static/mesos.css 255219f09b1ec9cecd96bf4517c7e184264810b5
>
> Diff: https://reviews.apache.org/r/12279/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ross Allen
>
>