You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (Created) (JIRA)" <ji...@apache.org> on 2011/12/08 01:48:39 UTC
[jira] [Created] (ZOOKEEPER-1322) Cleanup/fix logging in Quorum
code.
Cleanup/fix logging in Quorum code.
-----------------------------------
Key: ZOOKEEPER-1322
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1322
Project: ZooKeeper
Issue Type: Improvement
Components: server
Affects Versions: 3.4.0, 3.5.0
Reporter: Patrick Hunt
Assignee: Patrick Hunt
Fix For: 3.5.0, 3.4.1
While triaging ZOOKEEPER-1319 I updated the code with the attached patch in order to help debug what was going on with that issue. I think it would be useful to include these changes in the project itself. ff to include in 3.4.1 or push to 3.5.0.
You should verify this with TRACE logging turned on in addition to INFO (default).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1322) Cleanup/fix logging in Quorum
code.
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164919#comment-13164919 ]
Hadoop QA commented on ZOOKEEPER-1322:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12506554/ZOOKEEPER-1322_trunk.patch
against trunk revision 1208979.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/811//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/811//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/811//console
This message is automatically generated.
> Cleanup/fix logging in Quorum code.
> -----------------------------------
>
> Key: ZOOKEEPER-1322
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1322
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.4.0, 3.5.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.5.0, 3.4.1
>
> Attachments: ZOOKEEPER-1322_br34.patch, ZOOKEEPER-1322_trunk.patch
>
>
> While triaging ZOOKEEPER-1319 I updated the code with the attached patch in order to help debug what was going on with that issue. I think it would be useful to include these changes in the project itself. ff to include in 3.4.1 or push to 3.5.0.
> You should verify this with TRACE logging turned on in addition to INFO (default).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1322) Cleanup/fix logging in Quorum
code.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13201212#comment-13201212 ]
Hudson commented on ZOOKEEPER-1322:
-----------------------------------
Integrated in ZooKeeper-trunk #1451 (See [https://builds.apache.org/job/ZooKeeper-trunk/1451/])
ZOOKEEPER-1322. Cleanup/fix logging in Quorum code. (phunt via mahadev)
mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240921
Files :
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/Leader.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
> Cleanup/fix logging in Quorum code.
> -----------------------------------
>
> Key: ZOOKEEPER-1322
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1322
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.4.0, 3.5.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.4.3, 3.5.0
>
> Attachments: ZOOKEEPER-1322_br34.patch, ZOOKEEPER-1322_trunk.patch
>
>
> While triaging ZOOKEEPER-1319 I updated the code with the attached patch in order to help debug what was going on with that issue. I think it would be useful to include these changes in the project itself. ff to include in 3.4.1 or push to 3.5.0.
> You should verify this with TRACE logging turned on in addition to INFO (default).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1322) Cleanup/fix logging in Quorum
code.
Posted by "Mahadev konar (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-1322:
-------------------------------------
Fix Version/s: (was: 3.4.1)
3.4.2
Moving it out to 3.4.2, we'll have to investigate the failing tests.
> Cleanup/fix logging in Quorum code.
> -----------------------------------
>
> Key: ZOOKEEPER-1322
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1322
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.4.0, 3.5.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.5.0, 3.4.2
>
> Attachments: ZOOKEEPER-1322_br34.patch, ZOOKEEPER-1322_trunk.patch
>
>
> While triaging ZOOKEEPER-1319 I updated the code with the attached patch in order to help debug what was going on with that issue. I think it would be useful to include these changes in the project itself. ff to include in 3.4.1 or push to 3.5.0.
> You should verify this with TRACE logging turned on in addition to INFO (default).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1322) Cleanup/fix logging in Quorum
code.
Posted by "Mahadev konar (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13201072#comment-13201072 ]
Mahadev konar commented on ZOOKEEPER-1322:
------------------------------------------
Pat,
Went through the patch. Looks harmless to me. Kicking off hudson again to run through the patch again.
> Cleanup/fix logging in Quorum code.
> -----------------------------------
>
> Key: ZOOKEEPER-1322
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1322
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.4.0, 3.5.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.4.3, 3.5.0
>
> Attachments: ZOOKEEPER-1322_br34.patch, ZOOKEEPER-1322_trunk.patch
>
>
> While triaging ZOOKEEPER-1319 I updated the code with the attached patch in order to help debug what was going on with that issue. I think it would be useful to include these changes in the project itself. ff to include in 3.4.1 or push to 3.5.0.
> You should verify this with TRACE logging turned on in addition to INFO (default).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1322) Cleanup/fix logging in Quorum
code.
Posted by "Patrick Hunt (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165622#comment-13165622 ]
Patrick Hunt commented on ZOOKEEPER-1322:
-----------------------------------------
I don't think it's this patch - given it passed once and failed the second time.
quick look shows
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/817//testReport/org.apache.zookeeper.test/QuorumZxidSyncTest/testBehindLeader/
which is an intermittent failure I would think (can't agree who the leader is, but I don't see anything related to this patch in there. Take a look at time 2011-12-08 21:03:40,921 and prior.
I'll trigger the patch test again.
It's fine to wait post 3.4.1, good idea.
> Cleanup/fix logging in Quorum code.
> -----------------------------------
>
> Key: ZOOKEEPER-1322
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1322
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.4.0, 3.5.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.5.0, 3.4.2
>
> Attachments: ZOOKEEPER-1322_br34.patch, ZOOKEEPER-1322_trunk.patch
>
>
> While triaging ZOOKEEPER-1319 I updated the code with the attached patch in order to help debug what was going on with that issue. I think it would be useful to include these changes in the project itself. ff to include in 3.4.1 or push to 3.5.0.
> You should verify this with TRACE logging turned on in addition to INFO (default).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1322) Cleanup/fix logging in Quorum
code.
Posted by "Patrick Hunt (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-1322:
------------------------------------
Attachment: ZOOKEEPER-1322_trunk.patch
two patches to improve logging in the quorum code.
> Cleanup/fix logging in Quorum code.
> -----------------------------------
>
> Key: ZOOKEEPER-1322
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1322
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.4.0, 3.5.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.5.0, 3.4.1
>
> Attachments: ZOOKEEPER-1322_br34.patch, ZOOKEEPER-1322_trunk.patch
>
>
> While triaging ZOOKEEPER-1319 I updated the code with the attached patch in order to help debug what was going on with that issue. I think it would be useful to include these changes in the project itself. ff to include in 3.4.1 or push to 3.5.0.
> You should verify this with TRACE logging turned on in addition to INFO (default).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1322) Cleanup/fix logging in Quorum
code.
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165564#comment-13165564 ]
Hadoop QA commented on ZOOKEEPER-1322:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12506554/ZOOKEEPER-1322_trunk.patch
against trunk revision 1208979.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/817//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/817//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/817//console
This message is automatically generated.
> Cleanup/fix logging in Quorum code.
> -----------------------------------
>
> Key: ZOOKEEPER-1322
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1322
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.4.0, 3.5.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.5.0, 3.4.1
>
> Attachments: ZOOKEEPER-1322_br34.patch, ZOOKEEPER-1322_trunk.patch
>
>
> While triaging ZOOKEEPER-1319 I updated the code with the attached patch in order to help debug what was going on with that issue. I think it would be useful to include these changes in the project itself. ff to include in 3.4.1 or push to 3.5.0.
> You should verify this with TRACE logging turned on in addition to INFO (default).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1322) Cleanup/fix logging in Quorum
code.
Posted by "Patrick Hunt (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-1322:
------------------------------------
Attachment: ZOOKEEPER-1322_br34.patch
> Cleanup/fix logging in Quorum code.
> -----------------------------------
>
> Key: ZOOKEEPER-1322
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1322
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.4.0, 3.5.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.5.0, 3.4.1
>
> Attachments: ZOOKEEPER-1322_br34.patch, ZOOKEEPER-1322_trunk.patch
>
>
> While triaging ZOOKEEPER-1319 I updated the code with the attached patch in order to help debug what was going on with that issue. I think it would be useful to include these changes in the project itself. ff to include in 3.4.1 or push to 3.5.0.
> You should verify this with TRACE logging turned on in addition to INFO (default).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1322) Cleanup/fix logging in Quorum
code.
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13201083#comment-13201083 ]
Hadoop QA commented on ZOOKEEPER-1322:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12506554/ZOOKEEPER-1322_trunk.patch
against trunk revision 1238176.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/939//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/939//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/939//console
This message is automatically generated.
> Cleanup/fix logging in Quorum code.
> -----------------------------------
>
> Key: ZOOKEEPER-1322
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1322
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.4.0, 3.5.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.4.3, 3.5.0
>
> Attachments: ZOOKEEPER-1322_br34.patch, ZOOKEEPER-1322_trunk.patch
>
>
> While triaging ZOOKEEPER-1319 I updated the code with the attached patch in order to help debug what was going on with that issue. I think it would be useful to include these changes in the project itself. ff to include in 3.4.1 or push to 3.5.0.
> You should verify this with TRACE logging turned on in addition to INFO (default).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1322) Cleanup/fix logging in Quorum
code.
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181144#comment-13181144 ]
Hadoop QA commented on ZOOKEEPER-1322:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12506554/ZOOKEEPER-1322_trunk.patch
against trunk revision 1227927.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/884//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/884//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/884//console
This message is automatically generated.
> Cleanup/fix logging in Quorum code.
> -----------------------------------
>
> Key: ZOOKEEPER-1322
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1322
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.4.0, 3.5.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.4.3, 3.5.0
>
> Attachments: ZOOKEEPER-1322_br34.patch, ZOOKEEPER-1322_trunk.patch
>
>
> While triaging ZOOKEEPER-1319 I updated the code with the attached patch in order to help debug what was going on with that issue. I think it would be useful to include these changes in the project itself. ff to include in 3.4.1 or push to 3.5.0.
> You should verify this with TRACE logging turned on in addition to INFO (default).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira