[GitHub] [spark] pan3793 commented on a diff in pull request #43151: [SPARK-45358][SQL][HIVE] Remove shim classes for Hive prior 2.0.0

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on code in PR #43151:
URL: https://github.com/apache/spark/pull/43151#discussion_r1339740756


##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala:
##########
@@ -255,11 +254,19 @@ private[client] sealed abstract class Shim {
   }
 }
 
-private class Shim_v0_12 extends Shim with Logging {
+private[client] class Shim_v2_0 extends Shim with Logging {
   // See HIVE-12224, HOLD_DDLTIME was broken as soon as it landed
   protected lazy val holdDDLTime = JBoolean.FALSE

Review Comment:
   right, removed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org