[GitHub] [hbase] Apache9 commented on a diff in pull request #5189: HBASE-27746 Check if the file system supports storage policy before invoking setStoragePolicy()

["Apache9 (via GitHub)" <gi...@apache.org>]

Apache9 commented on code in PR #5189:
URL: https://github.com/apache/hbase/pull/5189#discussion_r1173627795


##########
hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestFSUtils.java:
##########
@@ -415,8 +417,9 @@ public void testSetStoragePolicyDefault() throws Exception {
    * Note: currently the default policy is set to defer to HDFS and this case is to verify the
    * logic, will need to remove the check if the default policy is changed
    */
-  private void verifyNoHDFSApiInvocationForDefaultPolicy() {
+  private void verifyNoHDFSApiInvocationForDefaultPolicy() throws URISyntaxException, IOException {
     FileSystem testFs = new AlwaysFailSetStoragePolicyFileSystem();
+    testFs.initialize(new URI("hdfs://localhost/"), conf);

Review Comment:
   Can we not use the 'hdfs' scheme here? It is not HDFS, actually...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org