You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/05/29 16:21:02 UTC
[GitHub] [activemq-artemis] jbertram opened a new pull request #3153: ARTEMIS-2649 always over-write ORIG message props
jbertram opened a new pull request #3153:
URL: https://github.com/apache/activemq-artemis/pull/3153
ORIG message propertes like _AMQ_ORIG_ADDRESS are added to messages
during various broker operations (e.g. diverting a message, expiring a
message, etc.). However, if multiple operations try to set these
properties on the same message (e.g. administratively moving a message
which eventually gets sent to a dead-letter address) then important
details can be lost. This is particularly problematic when using
auto-created dead-letter or expiry resources which use filters based on
_AMQ_ORIG_ADDRESS and can lead to message loss.
This commit simply over-writes the existing ORIG properties rather than
preserving them so that the most recent information is available.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit closed pull request #3153: ARTEMIS-2649 always over-write ORIG message props
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3153:
URL: https://github.com/apache/activemq-artemis/pull/3153
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3153: ARTEMIS-2649 always over-write ORIG message props
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3153:
URL: https://github.com/apache/activemq-artemis/pull/3153#issuecomment-636208169
There are two test failures on the whole testsuite ATM:
- org.apache.activemq.artemis.tests.integration.divert.DivertTest.testSingleDivertWithExpiry
- org.apache.activemq.artemis.tests.integration.amqp.DLQAfterExpiredMessageTest.testDoubleTransfer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3153: ARTEMIS-2649 always over-write ORIG message props
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on a change in pull request #3153:
URL: https://github.com/apache/activemq-artemis/pull/3153#discussion_r432680709
##########
File path: docs/user-manual/en/copied-message-properties.md
##########
@@ -0,0 +1,37 @@
+# Properties for Copied Messages
+
+There are several operations within the broker that result in copying a
+message. These include:
+
+- Diverting a message from one address to another.
+- Moving an expired message from a queue to the configured `expiry-address`
+- Moving a message which has exceeded its `max-delivery-attempts` from a queue
+ to the configured `dead-letter-address`
+- Using the management API to administratively move messages from one queue to
+ another
+
+When this happens the body and properties of the original message are copied to
+a new message. However, the copying process removes some potentially important
+pieces of data so those are preserved in the following special message
+properties:
+
+- `_AMQ_ORIG_ADDRESS`
Review comment:
These are also documented in AMQP.
Perhaps you could merge the content of that section here, and add a note about message annotations for AMQP messages?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3153: ARTEMIS-2649 always over-write ORIG message props
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on a change in pull request #3153:
URL: https://github.com/apache/activemq-artemis/pull/3153#discussion_r432705232
##########
File path: docs/user-manual/en/copied-message-properties.md
##########
@@ -0,0 +1,37 @@
+# Properties for Copied Messages
+
+There are several operations within the broker that result in copying a
+message. These include:
+
+- Diverting a message from one address to another.
+- Moving an expired message from a queue to the configured `expiry-address`
+- Moving a message which has exceeded its `max-delivery-attempts` from a queue
+ to the configured `dead-letter-address`
+- Using the management API to administratively move messages from one queue to
+ another
+
+When this happens the body and properties of the original message are copied to
+a new message. However, the copying process removes some potentially important
+pieces of data so those are preserved in the following special message
+properties:
+
+- `_AMQ_ORIG_ADDRESS`
Review comment:
Can you just a link then, stating there are some small differences with AMQP messages perhaps?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jbertram commented on a change in pull request #3153: ARTEMIS-2649 always over-write ORIG message props
Posted by GitBox <gi...@apache.org>.
jbertram commented on a change in pull request #3153:
URL: https://github.com/apache/activemq-artemis/pull/3153#discussion_r432700349
##########
File path: docs/user-manual/en/copied-message-properties.md
##########
@@ -0,0 +1,37 @@
+# Properties for Copied Messages
+
+There are several operations within the broker that result in copying a
+message. These include:
+
+- Diverting a message from one address to another.
+- Moving an expired message from a queue to the configured `expiry-address`
+- Moving a message which has exceeded its `max-delivery-attempts` from a queue
+ to the configured `dead-letter-address`
+- Using the management API to administratively move messages from one queue to
+ another
+
+When this happens the body and properties of the original message are copied to
+a new message. However, the copying process removes some potentially important
+pieces of data so those are preserved in the following special message
+properties:
+
+- `_AMQ_ORIG_ADDRESS`
Review comment:
They're referenced in the AMQP documentation but only insofar as how they are translated. I think the AMQP doc is where that should be.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org