You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@archiva.apache.org by "Maria Catherine Tan (JIRA)" <ji...@codehaus.org> on 2011/03/14 06:11:22 UTC
[jira] Created: (MRM-1461) Delete repositories gracefully
Delete repositories gracefully
------------------------------
Key: MRM-1461
URL: http://jira.codehaus.org/browse/MRM-1461
Project: Archiva
Issue Type: Improvement
Reporter: Maria Catherine Tan
When deleting a repositories encountered a locked file or an nfs file, it should skip it and proceed to deleting the rest of the file instead of throwing an IOException immediately.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MRM-1461) Delete repositories gracefully
Posted by "Maria Catherine Tan (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRM-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maria Catherine Tan updated MRM-1461:
-------------------------------------
Attachment: MRM-1461-updated.patch
I updated the patch to use common-io's deleteQuietly
> Delete repositories gracefully
> ------------------------------
>
> Key: MRM-1461
> URL: http://jira.codehaus.org/browse/MRM-1461
> Project: Archiva
> Issue Type: Improvement
> Reporter: Maria Catherine Tan
> Attachments: MRM-1461-updated.patch, MRM-1461.patch
>
>
> When deleting a repositories encountered a locked file or an nfs file, it should skip it and proceed to deleting the rest of the file instead of throwing an IOException immediately.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRM-1461) Delete repositories gracefully
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRM-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=260109#action_260109 ]
Brett Porter commented on MRM-1461:
-----------------------------------
would it be better to use comons-io's deleteQuietly method, then just test for existence at the end?
> Delete repositories gracefully
> ------------------------------
>
> Key: MRM-1461
> URL: http://jira.codehaus.org/browse/MRM-1461
> Project: Archiva
> Issue Type: Improvement
> Reporter: Maria Catherine Tan
> Attachments: MRM-1461.patch
>
>
> When deleting a repositories encountered a locked file or an nfs file, it should skip it and proceed to deleting the rest of the file instead of throwing an IOException immediately.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MRM-1461) Delete repositories gracefully
Posted by "Maria Odea Ching (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRM-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maria Odea Ching closed MRM-1461.
---------------------------------
Resolution: Fixed
Patch reviewed and applied to trunk [-r1082160|http://svn.apache.org/viewvc?revision=1082160&view=revision]. Thanks for the patch Marica!
> Delete repositories gracefully
> ------------------------------
>
> Key: MRM-1461
> URL: http://jira.codehaus.org/browse/MRM-1461
> Project: Archiva
> Issue Type: Improvement
> Reporter: Maria Catherine Tan
> Assignee: Maria Odea Ching
> Attachments: MRM-1461-updated.patch, MRM-1461.patch
>
>
> When deleting a repositories encountered a locked file or an nfs file, it should skip it and proceed to deleting the rest of the file instead of throwing an IOException immediately.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MRM-1461) Delete repositories gracefully
Posted by "Maria Catherine Tan (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRM-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maria Catherine Tan updated MRM-1461:
-------------------------------------
Attachment: MRM-1461.patch
Attached patch
* created a FileUtil class to delete the directory gracefully.
** it will continue to delete the rest of the files even if it encountered a locked file or any file that it can't delete and will throw an IOException at the end
* replaced FileUtils.deleteDirectory with this class
> Delete repositories gracefully
> ------------------------------
>
> Key: MRM-1461
> URL: http://jira.codehaus.org/browse/MRM-1461
> Project: Archiva
> Issue Type: Improvement
> Reporter: Maria Catherine Tan
> Attachments: MRM-1461.patch
>
>
> When deleting a repositories encountered a locked file or an nfs file, it should skip it and proceed to deleting the rest of the file instead of throwing an IOException immediately.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRM-1461) Delete repositories gracefully
Posted by "Maria Catherine Tan (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRM-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=260147#action_260147 ]
Maria Catherine Tan commented on MRM-1461:
------------------------------------------
Ok, I did not see that it catches the exception after calling the cleanDirectory.
> Delete repositories gracefully
> ------------------------------
>
> Key: MRM-1461
> URL: http://jira.codehaus.org/browse/MRM-1461
> Project: Archiva
> Issue Type: Improvement
> Reporter: Maria Catherine Tan
> Attachments: MRM-1461.patch
>
>
> When deleting a repositories encountered a locked file or an nfs file, it should skip it and proceed to deleting the rest of the file instead of throwing an IOException immediately.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (MRM-1461) Delete repositories gracefully
Posted by "Maria Odea Ching (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRM-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maria Odea Ching reassigned MRM-1461:
-------------------------------------
Assignee: Maria Odea Ching
> Delete repositories gracefully
> ------------------------------
>
> Key: MRM-1461
> URL: http://jira.codehaus.org/browse/MRM-1461
> Project: Archiva
> Issue Type: Improvement
> Reporter: Maria Catherine Tan
> Assignee: Maria Odea Ching
> Attachments: MRM-1461-updated.patch, MRM-1461.patch
>
>
> When deleting a repositories encountered a locked file or an nfs file, it should skip it and proceed to deleting the rest of the file instead of throwing an IOException immediately.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MRM-1461) Delete repositories gracefully
Posted by "Maria Odea Ching (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRM-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maria Odea Ching updated MRM-1461:
----------------------------------
Fix Version/s: 1.4
> Delete repositories gracefully
> ------------------------------
>
> Key: MRM-1461
> URL: http://jira.codehaus.org/browse/MRM-1461
> Project: Archiva
> Issue Type: Improvement
> Reporter: Maria Catherine Tan
> Assignee: Maria Odea Ching
> Fix For: 1.4
>
> Attachments: MRM-1461-updated.patch, MRM-1461.patch
>
>
> When deleting a repositories encountered a locked file or an nfs file, it should skip it and proceed to deleting the rest of the file instead of throwing an IOException immediately.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRM-1461) Delete repositories gracefully
Posted by "Maria Catherine Tan (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRM-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=260146#action_260146 ]
Maria Catherine Tan commented on MRM-1461:
------------------------------------------
If you use deleteQuietly to delete a directory, it will just call the cleanDirectory method which is just similar to calling deleteDirectory.
> Delete repositories gracefully
> ------------------------------
>
> Key: MRM-1461
> URL: http://jira.codehaus.org/browse/MRM-1461
> Project: Archiva
> Issue Type: Improvement
> Reporter: Maria Catherine Tan
> Attachments: MRM-1461.patch
>
>
> When deleting a repositories encountered a locked file or an nfs file, it should skip it and proceed to deleting the rest of the file instead of throwing an IOException immediately.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira