You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by Bill Havanki <bh...@clouderagovt.com> on 2013/12/03 18:28:50 UTC
Re: Review Request 15857: ACCUMULO-1931 - Javadoc for core.data
> On Nov. 27, 2013, 3:43 a.m., Sean Busbey wrote:
> > core/src/main/java/org/apache/accumulo/core/data/Column.java, lines 179-183
> > <https://reviews.apache.org/r/15857/diff/1/?file=391168#file391168line179>
> >
> > worth noting that the member is passed back directly and is thus modifiable by the caller?
Noted.
> On Nov. 27, 2013, 3:43 a.m., Sean Busbey wrote:
> > core/src/main/java/org/apache/accumulo/core/data/Column.java, lines 188-192
> > <https://reviews.apache.org/r/15857/diff/1/?file=391168#file391168line188>
> >
> > worth noting that the member is passed back directly and is thus modifiable by the caller?
Noted.
> On Nov. 27, 2013, 3:43 a.m., Sean Busbey wrote:
> > core/src/main/java/org/apache/accumulo/core/data/Column.java, lines 197-201
> > <https://reviews.apache.org/r/15857/diff/1/?file=391168#file391168line197>
> >
> > worth noting that the member is passed back directly and is thus modifiable by the caller?
Noted.
> On Nov. 27, 2013, 3:43 a.m., Sean Busbey wrote:
> > core/src/main/java/org/apache/accumulo/core/data/ColumnUpdate.java, lines 75-79
> > <https://reviews.apache.org/r/15857/diff/1/?file=391169#file391169line75>
> >
> > worth noting that the member is passed back directly and is thus modifiable by the caller?
Noted.
> On Nov. 27, 2013, 3:43 a.m., Sean Busbey wrote:
> > core/src/main/java/org/apache/accumulo/core/data/ColumnUpdate.java, lines 84-88
> > <https://reviews.apache.org/r/15857/diff/1/?file=391169#file391169line84>
> >
> > worth noting that the member is passed back directly and is thus modifiable by the caller?
Noted.
> On Nov. 27, 2013, 3:43 a.m., Sean Busbey wrote:
> > core/src/main/java/org/apache/accumulo/core/data/Mutation.java, lines 50-51
> > <https://reviews.apache.org/r/15857/diff/1/?file=391175#file391175line50>
> >
> > Worth noting that a delete marker will hide any entries for that row column with an earlier timestamp? And that Accumulo will eventually remove said data from disk as a part of normal garbage collection?
Noted.
> On Nov. 27, 2013, 3:43 a.m., Sean Busbey wrote:
> > core/src/main/java/org/apache/accumulo/core/data/Mutation.java, lines 64-66
> > <https://reviews.apache.org/r/15857/diff/1/?file=391175#file391175line64>
> >
> > Any chance for @since markers on these versions, or a pointer here to their details / differences?
The enum was introduced in Accumulo 1.5 with both values, so @since won't be helpful. I will need to look for docs on the differences, or maybe note it here.
> On Nov. 27, 2013, 3:43 a.m., Sean Busbey wrote:
> > core/src/main/java/org/apache/accumulo/core/data/Range.java, lines 179-190
> > <https://reviews.apache.org/r/15857/diff/1/?file=391177#file391177line179>
> >
> > Are we sure this constructor purposefully allows the end key to be before the start key?
> >
> > including it in the javadocs here makes it expected behavior for the future, rather than a potential bug.
I dropped mention of this method permitting end key < start key. This constructor appears unused (outside Range, anyway), and so I think we should open a JIRA to either remove it or fix it.
> On Nov. 27, 2013, 3:43 a.m., Sean Busbey wrote:
> > core/src/main/java/org/apache/accumulo/core/data/Value.java, lines 78-79
> > <https://reviews.apache.org/r/15857/diff/1/?file=391178#file391178line78>
> >
> > Maybe the above should say the copy flag can indicate that the caller wants to force a copy?
> >
> > then this comment could be a TODO to indicate that toBytes means we always copy at least once, and twice when copy is true?
Doing a double copy doesn't make any sense to me. The Javadoc I have is my closest interpretation to what the interface means, regardless of what it does. I'm going to file a JIRA about this one for further investigation.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15857/#review29477
-----------------------------------------------------------
On Nov. 26, 2013, 1:13 p.m., Bill Havanki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15857/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2013, 1:13 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-1931
> https://issues.apache.org/jira/browse/ACCUMULO-1931
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Javadoc additions and updates to classes in org.apache.accumulo.core.data.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/accumulo/core/data/ArrayByteSequence.java eaa61b9950b691ed5955af3178a3aa939291e8bf
> core/src/main/java/org/apache/accumulo/core/data/ByteSequence.java 4dc921c5efc44d374032c623f50e4218aa6c7299
> core/src/main/java/org/apache/accumulo/core/data/Column.java a56c01d6604a30153739ed1329d034e3932f2e2f
> core/src/main/java/org/apache/accumulo/core/data/ColumnUpdate.java 641ca3a740ed384ab93f4b2d3c08c928daadfb2f
> core/src/main/java/org/apache/accumulo/core/data/ComparableBytes.java ce61844375617c36ede5e0e411b439205329b023
> core/src/main/java/org/apache/accumulo/core/data/Condition.java fc8f2bf0394ae658bacfa94804b4b81f19a0c0c2
> core/src/main/java/org/apache/accumulo/core/data/ConstraintViolationSummary.java 2929bc610df9352374621d29caea7732bd50847d
> core/src/main/java/org/apache/accumulo/core/data/Key.java de9e22d9ebff5442633dc578613fd7d033afc9c5
> core/src/main/java/org/apache/accumulo/core/data/KeyValue.java cc48322f9785ad508cc7925279f5e559629f3721
> core/src/main/java/org/apache/accumulo/core/data/Mutation.java 5e281f2bfef7e164c9f0e0c9a7132e94012d7186
> core/src/main/java/org/apache/accumulo/core/data/PartialKey.java 2049881fe26b5f237db39a412a88e2e2017f5cc9
> core/src/main/java/org/apache/accumulo/core/data/Range.java 70857348cefd0941e5ffcf6e5d569f09870101e4
> core/src/main/java/org/apache/accumulo/core/data/Value.java 7d3cf8f20aa12205d25027d6ad06e4a3f6062b2e
> core/src/main/java/org/apache/accumulo/core/util/UnsynchronizedBuffer.java b640581bebbb87f1ac9a36f71275fa5dc8ef1223
>
> Diff: https://reviews.apache.org/r/15857/diff/
>
>
> Testing
> -------
>
> Compiled successfully; mvn javadoc:javadoc ran with no errors from the javadoc in this patch.
>
>
> Thanks,
>
> Bill Havanki
>
>