You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/03/09 11:38:13 UTC
[GitHub] [iceberg] snazy opened a new pull request #2307: Bump Nessie to version 0.4.0
snazy opened a new pull request #2307:
URL: https://github.com/apache/iceberg/pull/2307
Contains some "noise" due to the renamed package `com.dremio.nessie` -> `org.projectnessie`.
Implicitly bumps Quarkus to 1.12.1.Final
Quarkus image building requires us to set the system property `quarkus.build.native-image`, which is not particularly
great and should be changed in the future on the Nessie-Quarkus-Gradle-Plugin side. It is a change in the behavior
since Quarkus 1.10 (Nessie 0.3.0 used Quarkus 1.9.1.Final) regarding how the Quarkus platform properties are applied,
which sadly also affects Quarkus builds that do not build a native image. Playing around with applying the Quarkus
bom, as suggested by Quarkus project, in various places (Gradle configs) didn't help here. I suspect, that's some
transitive dependency resolving issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] danielcweeks merged pull request #2307: Bump Nessie to version 0.4.0
Posted by GitBox <gi...@apache.org>.
danielcweeks merged pull request #2307:
URL: https://github.com/apache/iceberg/pull/2307
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rymurr commented on pull request #2307: Bump Nessie to version 0.4.0
Posted by GitBox <gi...@apache.org>.
rymurr commented on pull request #2307:
URL: https://github.com/apache/iceberg/pull/2307#issuecomment-799531623
Much obliged @danielcweeks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #2307: Bump Nessie to version 0.4.0
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on a change in pull request #2307:
URL: https://github.com/apache/iceberg/pull/2307#discussion_r594441288
##########
File path: build.gradle
##########
@@ -1102,7 +1102,10 @@ project(':iceberg-nessie') {
quarkusAppRunnerProperties {
props = ["quarkus.http.test-port": 0]
}
- tasks.getByName("quarkus-start").dependsOn("compileTestJava")
+ tasks.getByName("quarkus-start")
+ // This is not doing anything with Docker or building a native image, just a quirk of in Quarkus since 1.10.
Review comment:
quark of quirkus
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rymurr commented on a change in pull request #2307: Bump Nessie to version 0.4.0
Posted by GitBox <gi...@apache.org>.
rymurr commented on a change in pull request #2307:
URL: https://github.com/apache/iceberg/pull/2307#discussion_r590269824
##########
File path: build.gradle
##########
@@ -1102,7 +1102,10 @@ project(':iceberg-nessie') {
quarkusAppRunnerProperties {
props = ["quarkus.http.test-port": 0]
}
- tasks.getByName("quarkus-start").dependsOn("compileTestJava")
+ tasks.getByName("quarkus-start")
+ // This is not doing anything with Docker or building a native image, just a quirk of in Quarkus since 1.10.
Review comment:
> quirk of in Quarkus
nit: quirk of Quarkus
##########
File path: nessie/src/test/java/org/apache/iceberg/nessie/BaseTestIceberg.java
##########
@@ -103,7 +103,7 @@ NessieCatalog initCatalog(String ref) {
NessieCatalog newCatalog = new NessieCatalog();
newCatalog.setConf(hadoopConfig);
newCatalog.initialize("nessie", ImmutableMap.of("ref", ref,
- "url", path,
+ "uri", path,
Review comment:
this can use `CatalogProperties`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] danielcweeks commented on pull request #2307: Bump Nessie to version 0.4.0
Posted by GitBox <gi...@apache.org>.
danielcweeks commented on pull request #2307:
URL: https://github.com/apache/iceberg/pull/2307#issuecomment-799531130
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org