You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2020/01/20 06:45:19 UTC
[GitHub] [libcloud] Kami opened a new pull request #1414: Fix incorrect type
annotations in the base compute API
Kami opened a new pull request #1414: Fix incorrect type annotations in the base compute API
URL: https://github.com/apache/libcloud/pull/1414
This pull request fixes a couple of incorrect type annotations in the base compute API as reported by #1413.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] codecov-io edited a comment on issue #1414: Fix
incorrect type annotations in the base compute API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1414: Fix incorrect type annotations in the base compute API
URL: https://github.com/apache/libcloud/pull/1414#issuecomment-576131193
# [Codecov](https://codecov.io/gh/apache/libcloud/pull/1414?src=pr&el=h1) Report
> Merging [#1414](https://codecov.io/gh/apache/libcloud/pull/1414?src=pr&el=desc) into [trunk](https://codecov.io/gh/apache/libcloud/commit/bb865b1ee029b9bceaa83917c9b9f7b16033547e?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/libcloud/pull/1414?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## trunk #1414 +/- ##
=======================================
Coverage 86.46% 86.46%
=======================================
Files 366 366
Lines 76791 76791
Branches 7529 7529
=======================================
Hits 66396 66396
Misses 7527 7527
Partials 2868 2868
```
| [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1414?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [libcloud/compute/base.py](https://codecov.io/gh/apache/libcloud/pull/1414/diff?src=pr&el=tree#diff-bGliY2xvdWQvY29tcHV0ZS9iYXNlLnB5) | `93.7% <100%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1414?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1414?src=pr&el=footer). Last update [bb865b1...edb9402](https://codecov.io/gh/apache/libcloud/pull/1414?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] Kami commented on a change in pull request #1414: Fix
incorrect type annotations in the base compute API
Posted by GitBox <gi...@apache.org>.
Kami commented on a change in pull request #1414: Fix incorrect type annotations in the base compute API
URL: https://github.com/apache/libcloud/pull/1414#discussion_r368389288
##########
File path: libcloud/compute/base.py
##########
@@ -822,7 +822,7 @@ class NodeDriver(BaseDriver):
name = None # type: str
api_name = None # type: str
website = None # type: str
- type = None # type: Provider
+ type = None # type: Union[Provider,str]
Review comment:
NOTE: Ideally this would always be ``Provider`` enum, but a lot of the existing code uses ``str`` type so we still need to support it for backward compatibility reasons.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] codecov-io commented on issue #1414: Fix incorrect type
annotations in the base compute API
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1414: Fix incorrect type annotations in the base compute API
URL: https://github.com/apache/libcloud/pull/1414#issuecomment-576131193
# [Codecov](https://codecov.io/gh/apache/libcloud/pull/1414?src=pr&el=h1) Report
> Merging [#1414](https://codecov.io/gh/apache/libcloud/pull/1414?src=pr&el=desc) into [trunk](https://codecov.io/gh/apache/libcloud/commit/bb865b1ee029b9bceaa83917c9b9f7b16033547e?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/libcloud/pull/1414?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## trunk #1414 +/- ##
=======================================
Coverage 86.46% 86.46%
=======================================
Files 366 366
Lines 76791 76791
Branches 7529 7529
=======================================
Hits 66396 66396
Misses 7527 7527
Partials 2868 2868
```
| [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1414?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [libcloud/compute/base.py](https://codecov.io/gh/apache/libcloud/pull/1414/diff?src=pr&el=tree#diff-bGliY2xvdWQvY29tcHV0ZS9iYXNlLnB5) | `93.7% <100%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1414?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1414?src=pr&el=footer). Last update [bb865b1...edb9402](https://codecov.io/gh/apache/libcloud/pull/1414?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] Kami merged pull request #1414: Fix incorrect type
annotations in the base compute API
Posted by GitBox <gi...@apache.org>.
Kami merged pull request #1414: Fix incorrect type annotations in the base compute API
URL: https://github.com/apache/libcloud/pull/1414
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services