You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/03/02 22:07:26 UTC
Review Request: Fixed mesos-build-env.sh to set missing environment
variables.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9715/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
There has been a regression in that the example frameworks don't run unless both MESOS_BUILD_DIR and MESOS_SOURCE_DIR are explicitly set:
MESOS_BUILD_DIR=/home/bmahler/git/mesos/build MESOS_SOURCE_DIR=/home/bmahler/git/mesos ./src/long-lived-framework localhost:5050
This addresses bugs MESOS-163 and MESOS-341.
https://issues.apache.org/jira/browse/MESOS-163
https://issues.apache.org/jira/browse/MESOS-341
Diffs
-----
bin/mesos-build-env.sh.in 31bccad3fab133dcb67670a2727b8ce433f62f70
Diff: https://reviews.apache.org/r/9715/diff/
Testing
-------
make check
Ran the long-lived framework
Thanks,
Ben Mahler
Re: Review Request: Fixed mesos-build-env.sh to set missing environment
variables.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9715/#review17316
-----------------------------------------------------------
Can you also test example frameworks as follows:
make check TESTS="<example-framework>"
./bin/mesos-tests.sh --gtest-filter="<example-framework>"
./src/<example-framework>.sh
- Vinod Kone
On March 2, 2013, 9:07 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9715/
> -----------------------------------------------------------
>
> (Updated March 2, 2013, 9:07 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> There has been a regression in that the example frameworks don't run unless both MESOS_BUILD_DIR and MESOS_SOURCE_DIR are explicitly set:
>
> MESOS_BUILD_DIR=/home/bmahler/git/mesos/build MESOS_SOURCE_DIR=/home/bmahler/git/mesos ./src/long-lived-framework localhost:5050
>
>
> This addresses bugs MESOS-163 and MESOS-341.
> https://issues.apache.org/jira/browse/MESOS-163
> https://issues.apache.org/jira/browse/MESOS-341
>
>
> Diffs
> -----
>
> bin/mesos-build-env.sh.in 31bccad3fab133dcb67670a2727b8ce433f62f70
>
> Diff: https://reviews.apache.org/r/9715/diff/
>
>
> Testing
> -------
>
> make check
> Ran the long-lived framework
>
>
> Thanks,
>
> Ben Mahler
>
>