[jira] [Comment Edited] (NIFI-7052) UI - Processor details dialog with Advanced button

["Nagasivanath Dasari (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-7052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17020788#comment-17020788 ] 

Nagasivanath Dasari edited comment on NIFI-7052 at 1/22/20 5:52 AM:
--------------------------------------------------------------------

can you give the scenario, in which case you get this issue?

I checked the code, there is a condition for whether the current window is top window or not, for the display of the advanced button

if (*top === window* && b.isDefinedAndNotNull(h) && b.isDefinedAndNotNull(p.config.customUiUrl) && p.config.customUiUrl !== "") 

So, in case of summary page, as its an iframe, while showing the advanced button, this condition should be false and the button shouldn't be shown


was (Author: nagasivanath):
can you tell me, in which case you are able to get this issue?

I checked the code, there is a condition for whether the current window is top window or not, for the display of the advanced button

if (*top === window* && b.isDefinedAndNotNull(h) && b.isDefinedAndNotNull(p.config.customUiUrl) && p.config.customUiUrl !== "") 

So, in case of summary page, as its an iframe, while showing the advanced button, this condition should be false and the button shouldn't be shown

> UI - Processor details dialog with Advanced button
> --------------------------------------------------
>
>                 Key: NIFI-7052
>                 URL: https://issues.apache.org/jira/browse/NIFI-7052
>             Project: Apache NiFi
>          Issue Type: Task
>          Components: Core UI
>            Reporter: Matt Gilman
>            Priority: Major
>
> The processor configuration and processor details dialog can optionally contain a button that launches the processor advanced UI. This Advanced button does not work correctly when the Summary page is popped out of the primary UI. I believe that in this case, we should disable/hide the Advanced button feature when the Summary page is popped out.
> {code:java}
> nf-custom-ui.js?1.11.0-SNAPSHOT:79 Uncaught TypeError: Cannot read property 'showPage' of undefined
>     at nf-custom-ui.js?1.11.0-SNAPSHOT:79
>     at c (jquery.min.js:2)
>     at Object.add [as done] (jquery.min.js:2)
>     at Object.<anonymous> (nf-custom-ui.js?1.11.0-SNAPSHOT:58)
>     at Function.Deferred (jquery.min.js:2)
>     at Object.showCustomUi (nf-custom-ui.js?1.11.0-SNAPSHOT:57)
>     at k.fn.init.click (nf-processor-details.js?1.11.0-SNAPSHOT:325)
>     at HTMLDivElement.<anonymous> (jquery.modal.js?1.11.0-SNAPSHOT:143)
>     at HTMLDivElement.dispatch (jquery.min.js:2)
>     at HTMLDivElement.$event.dispatch (jquery.event.drag-2.3.0.js:382)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)