You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/29 07:43:21 UTC
[GitHub] [pulsar] gaoran10 opened a new pull request #8739: [Tiered Storage] Offload manager initialization once
gaoran10 opened a new pull request #8739:
URL: https://github.com/apache/pulsar/pull/8739
### Motivation
Currently, the offload manager will be initialized when creating the ledger offloader.
### Modifications
Initialize the offloader manager when starting the Pulsar service.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #8739: [Tiered Storage] Offload manager initialization once
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #8739:
URL: https://github.com/apache/pulsar/pull/8739#issuecomment-796425605
@sijie and @gaoran10 - I just ran into the class loader leak that this PR corrects. However, I notice that we switch from `offloadPolicies.getOffloadersDirectory()` to `config.getOffloadersDirectory()` for the first argument of the `OffloaderUtils.searchForOffloaders` method. That argument is the directory to search for the `.nar` files. As such, the `offloaderDirectory` won't be able to be overriden at the namespace level. I opened up #9878 to restore the ability to overload the directory. Please take a look at the PR, if you have time. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #8739: [Tiered Storage] Offload manager initialization once
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #8739:
URL: https://github.com/apache/pulsar/pull/8739
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #8739: [Tiered Storage] Offload manager initialization once
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #8739:
URL: https://github.com/apache/pulsar/pull/8739#issuecomment-735526759
/pulsarbot cherry-pick to branch-2.7
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org