[GitHub] [pinot] jtao15 commented on a diff in pull request #8838: Wait segment deletion in startReplaceSegment api to make sure there will be at most 2 data snapshots.

[GitBox <gi...@apache.org>]

jtao15 commented on code in PR #8838:
URL: https://github.com/apache/pinot/pull/8838#discussion_r891670095


##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -173,6 +173,8 @@ public class PinotHelixResourceManager {
   // TODO: make this configurable
   public static final long EXTERNAL_VIEW_ONLINE_SEGMENTS_MAX_WAIT_MS = 10 * 60_000L; // 10 minutes
   public static final long EXTERNAL_VIEW_CHECK_INTERVAL_MS = 1_000L; // 1 second
+  public static final long SEGMENT_CLEANUP_TIMEOUT_MS = 20 * 60_000L; // 20 minutes

Review Comment:
   Usually the deletion should be fast, but for large multi-tenants cluster, helix can be slow for updating the externalview even if the actual state on server side has changed (> 10 mins). Segment deletion will 1. update idealstate 2. wait externalview to converge 3. remove zk metadata. I'm putting this as 20 mins by considering the helix delay.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org