[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #895: MINIFICPP-1352 - Comment out unused parameters (for enabling -Wall)

[GitBox <gi...@apache.org>]

lordgamez commented on a change in pull request #895:
URL: https://github.com/apache/nifi-minifi-cpp/pull/895#discussion_r484897206



##########
File path: extensions/civetweb/processors/ListenHTTP.cpp
##########
@@ -211,7 +211,7 @@ void ListenHTTP::onSchedule(core::ProcessContext *context, core::ProcessSessionF
 
 ListenHTTP::~ListenHTTP() = default;
 
-void ListenHTTP::onTrigger(core::ProcessContext *context, core::ProcessSession *session) {
+void ListenHTTP::onTrigger(core::ProcessContext* /*context*/, core::ProcessSession *session) {

Review comment:
       I would remove commented variables where the parameter is self-explanatory or has even less meaning than the typename, like ProcessContext - context, CivetServer - server, Configure - configure, ProcessSessionFactory - sessionFactory, ProcessGroup - pg, Parameters params, Repository - repo and so on. If you have an idea it could be filtered and replaced easily go ahead, if it would be too exhausting, just leave it for now.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org